194651 - Need workaround for crashers in nsRenderingContextXlib::GetTextDimensions()

Status: RESOLVED INVALID

(Core Graveyard :: Printing: Xprint, defect)

Description

[Roland Mainz]

[spin-off of bug 194644 ("Talkback crashes in Xprint module
[nsRenderingContextXlib::GetTextDimensions()]"):]
We need a workaround for crashers in
|nsRenderingContextXlib::GetTextDimensions()|.
Current feedback from Talkback is not very precise so I propose to turn the
"fast text measuring"-codepath "off" for now until we find the root of the
issue.

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Attachment: Patch for 2003-02-07-08-trunk

The patch turns the "fast text measuring code" "off" by default.
It can still be enabled by setting the |MOZILLA_GFX_ENABLE_FAST_MEASURE| env
var.

Comment 3

[Roland Mainz]

Nice side-effect:
Some issues related to BiDi are being worked-around by this patch, too (smontagu
has a patch for that but that may likely not part of 1.3final, however this
patch is (nearly) risk-free so taking it for 1.3final will likely not harm
anyone... :)

Comment 4

[Roland Mainz]

Comment on attachment 115342 [details] [diff] [review]
Patch for 2003-02-07-08-trunk

Requesting r= and sr= ...

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 115342 [details] [diff] [review]
Patch for 2003-02-07-08-trunk

r=smontagu for the branch. I imagine drivers will want an explicit statement of
the impact of this change.

Comment 6

[rbs]

Comment on attachment 115342 [details] [diff] [review]
Patch for 2003-02-07-08-trunk

Unsetting the flags since the correct fix has been found in bug  194644.

Comment 7

[rbs]

-> invalid, not needed anymore.

Comment 8

[Roland Mainz]

rbs wrote:
> -> invalid, not needed anymore.

Depends on whether [e-mail] will approve the patch in bug 194644...
;-/