1946586 - Opaque region not set with SW-WR

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Robert Mader [:rmader]]

Similar to bug 1933823 the opaque region does not get set when using the SW-WR.

STR:

• run a Gnome session and enable the opaque overlay (alt+f2->lg->Flags->OPAQUE_REGION)
• run FF with SW-WR

Tested on 135 and nightly (from today, 137)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Curious if it's s regression tho?

Comment 2

[Robert Mader [:rmader]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Curious if it's s regression tho?

It worked at some point a year or two ago :P But didn't have time to run mozregression yet.

Comment 3

[Kestrel]

Same regressor as Bug 1933823.

Note that new windows need to be resized for the opaque region to be applied with SW-WR while it gets applied immediately with HW-WR.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aa6305a65fb5e7e7a9a1c0b572cdb0e2d4dac4fc&tochange=05fe9b71651f981ada58733864135b940f9c27b0

Regressed by Bug 1915230.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This probably means that this broke sometime in-between bug 1915230 landed, and bug 1908471 fixed it...

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1946586 - Set opaque region even without an EGL window. r=stransky

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1946586 - Re-enable opaque regions on popups as well. r=stransky

With bug 1967114 we get meaningful regions for popups (even with rounded
corners). Bug 1674473 doesn't seem like an issue anymore, so try to do
this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e58dcdd78673
https://hg.mozilla.org/integration/autoland/rev/f798ba3bc32f
Set opaque region even without an EGL window. r=stransky

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b2732b47df2
https://hg.mozilla.org/integration/autoland/rev/abdd8bcb3e14
Re-enable opaque regions on popups as well. r=stransky

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f798ba3bc32f
https://hg.mozilla.org/mozilla-central/rev/abdd8bcb3e14

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Can probably ride the trains.