1946642 - Unable to cleanup MockFilePicker if init called more than once

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Julian Descottes [:jdescottes]]

In a test, I was calling MockFilePicker.init() several times (unnecessarily).
The test worked fine on its own, but then on try when running the full test suite, another test started failing because it was calling MockFilePicker.cleanup() as a registerCleanupFunction.

If init() is called more than once we lose the reference to the factory which was registered and it's impossible to cleanup the MockFilePicker.
We should either fix it or throw early.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1946642 - MockFilePicker should handle multiple calls to init() gracefully

Calling init twice currently makes it impossible to cleanup the MockFilePicker later on.
This change will automatically call cleanup() in case a previous MockFilePicker factory was already
registered.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d7ade04a809
MockFilePicker should handle multiple calls to init() gracefully r=Gijs

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7d7ade04a809