1946647 - Panic button: icons for "Open a new clean Window" and "Delete Recent History" are backwards

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of panel

Icons are coming from chrome://browser/skin/panic-panel/icons.png

I assume this was regressed by bug 1853652.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1853652

:emilio, since you are the author of the regressor, bug 1853652, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1946647 - Fix icons in Panic button for history and new window, r=emilio!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks for catching this and submitting a patch!

Comment 5

[Francesco Lodolo [:flod]]

Credit for discovery goes to OP on Reddit, not sure if they also filed the dupllicate.
https://www.reddit.com/r/firefox/comments/1ijbh5x/arent_these_icons_supposed_to_be_the_other_way/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ef2dc35a3ec
Fix icons in Panic button for history and new window, r=emilio,desktop-theme-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0ef2dc35a3ec

Comment 8

[Francesco Lodolo [:flod]]

Attachment: Bug 1946647 - Fix icons in Panic button for history and new window, r=emilio!

Original Revision: https://phabricator.services.mozilla.com/D237177

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Two icons are backwards in panel
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: None
• Explanation of risk level: This is updating the CSS to pick up the correct icon
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Francesco Lodolo [:flod]]

Attachment: Bug 1946647 - Fix icons in Panic button for history and new window, r=emilio!

Original Revision: https://phabricator.services.mozilla.com/D237177

Comment 11

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Two items used the incorrect icons in panel
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: None
• Explanation of risk level: This is updating the CSS to pick up the correct icon
• String changes made/needed: None
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/66e919c3bcbe

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 137.0a1 (2025-02-06) on Windows 10x64. The Open a new window and Delete Recent History icons from the Forget about some browsing history are inversed.
The issue is verified fixed with Firefox 136.0b4 and 137.0a1 (2025-02-11) on Windows 10x64, macOS 12, and Ubuntu 24. The icons are in the correct position.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/e45f91f2cb4b