1946707 - Replacing notification with tag fires events with different order on libnotify; show happens before close

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Same as bug 1890560, but for libnotify backend. nsAlertsIconListener in this case defers calling alertfinish until it gets the close signal from the system, but given we call alertshow immediately after calling notify command, repeated opening of same-tagged notification causes wrong order of event (alertshow fires first while alertfinish waits for the system). Given we don't have a way to asynchronously wait for system for alertshow, we should immediately call alertfinish to make it consistent with alertshow.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1946707 - Call NotifyFinished earlier for existing listener r=stransky

This will let Linux pass the test in D237022.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fedd4d89a0ea
Call NotifyFinished earlier for existing listener r=stransky

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fedd4d89a0ea