1946714 - [contextual-password-manager] More options menu from Password sidebar fails to close on second click

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: video showing the issue

Found in

• 137.0a1 (2025-02-07)

Affected versions

• 137.0a1

Preconditions

• Add the pref ‘browser.contextual-password-manager.enabled’ in about:config and set it to true
• Have the Sidebar panel added to the browser toolbar and enabled

Tested platforms

• Affected platforms: macOS 13, Windows 11, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Click the "More options" menu (3 dot menu) from the Password sidebar
2. Click again the "More options" menu and observe the behavior

Expected result

• The "More options" menu closes on second click

Actual result

• The "More options" menu is still displayed

Regression range

• Not a regression, as this is a new feature

Additional notes

• See the attached video
• Not reproducing in about:logins

Comment 1

[Tessa Heidkamp]

Attachment: [WIP] Bug 1946714 - [contextual-password-manager] Fixing toggle function for more options menu. r=mtigley

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1946714 - [contextual-password-manager] Do not propagate mousedown r=mtigley

The propagated mousedown event causes <panel-list> to hide when clicked.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1750e1d4e5c
https://hg.mozilla.org/integration/autoland/rev/6f14ef1cbb9a
[contextual-password-manager] Do not propagate mousedown r=mtigley,credential-management-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6f14ef1cbb9a

Comment 5

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox 142.0b3 on Ubuntu 22.04, macOS 13 and Windows 11. More options menu from Password sidebar is now closing/opening accordingly.