1946718 - [contextual-password-manager] Add/Edit Password Forms are automatically dismissed after performing a search in Password sidebar

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: video showing the issue

Found in

• 137.0a1 (2025-02-07)

Affected versions

• 137.0a1

Preconditions

• Add the pref ‘browser.contextual-password-manager.enabled’ in about:config and set it to true
• Have the Sidebar panel added to the browser toolbar and enabled
• Have some saved logins

Tested platforms

• Affected platforms: macOS 13, Windows 11, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Click the "Add password" button or "Edit" button in the Password sidebar
2. Fill in all the fields or edit the existing values (do not press the "Save" button)
3. Enter some text in the Search box
4. Observe the behavior

Expected result

• Confirmation notification should be displayed
• The "Add/Edit password" form should remain open and not be automatically dismissed

Actual result

• Confirmation notification is not displayed
• The "Add/Edit password" form is automatically dismissed

Regression range

• Not a regression, as this is a new feature

Additional notes

• See the attached video
• Also reproducing when Edit password form is open and Add password button is clicked
• Also reproducing when switching between sidebar options

Comment 1

[Rebecca]

patch ready to land - high priority

Comment 2

[Dianna Smith [:diannaS]]

is this still a priority for 138?

Comment 3

[Micah [:mtigley] (she/her)]

This patch is still a high priority. The remaining work is to fix the existing tests and we will be ready to land.

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1946718 - [cpm] Hide toolbar when CPM is not in an empty state. r=dimi!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55d2d902ca87
https://hg.mozilla.org/integration/autoland/rev/9396a65ed903
[cpm] Hide toolbar when CPM is not in an empty state. r=dimi

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9396a65ed903

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screen Recording 2025-07-28 at 12.56.57.mov

Verified using Firefox 142.0b3 on Ubuntu 22.04, macOS 13 and Windows 11. CPM toolbar is no longer displayed when the Add or Edit forms are opened, so the issue is no longer reproducible.
However, the issue still reproduces when switching between sidebar options (as mentioned in the Additional notes section).
@Micah, should we reopen this or track the issue in a different bug? Thanks!

Comment 8

[Micah [:mtigley] (she/her)]

Hi Bianca! Thank you for re-testing. Let's create a follow-up issue for the problem still persisting when switching sidebars. The fix for this would be a little more complicated.

Comment 9

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Logged bug 1980147 for the issue when switching sidebars. Based on Comment 7, I'm marking this verified as fixed.