1946776 - Add support for accesskey to moz-box-button

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Hanna Jones [:hjones]]

We generally tend to support accesskeys on interactive elements, especially those that are used in settings. We should extend this support to our moz-box-button element so that it can more easily be activated by the keyboard. We will want it to be mapped and delegated to the inner button element in the component, similar to how we handle accesskeys in moz-button.

Comment 1

[Mark Striemer [:mstriemer]]

Acceptance Criteria:

1. Add the accesskey: { type: String, fluent: true, mapped: true } property to moz-box-button
2. Update the labelTemplate() function in MozBoxBase to use moz-label and set the accesskey if it is defined (searchfox)
   • <label is="moz-label accesskey=${ifDefined(this.accessKey)>${this.label}</label>

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1946776 - add accesskey support to moz-box-button r=#recomp-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a279aec9ee6f
add accesskey support to moz-box-button r=reusable-components-reviewers,akulyk

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a279aec9ee6f