1946805 - Count is not being incremented properly when excluding bugs from the full list and therefore the export script is hanging

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect, P1)

Description

[David Lawrence [:dkl]]

The new BMO ETL export script has a bug in that it does not properly increment the $count variable when encountering bugs that are to be skipped in the export. These include Legal bugs, etc. Then the while() loop runs forever as $count is always less than $total.

Bad code:

        if (any { $obj->product eq $_ } EXCLUDE_PRODUCTS) {
          $excluded_bugs{$obj->id} = 1;
          next;
        }

This should be instead:

        if (any { $obj->product eq $_ } EXCLUDE_PRODUCTS) {
          $excluded_bugs{$obj->id} = 1;
          $count++;
          next;
        }

I didn't not catch this unfortunately til we tried it in production as bugzilla-dev does not have any bugs to be excluded so the count was always correct.

Any other functions where we skip excluded bugs will also need to be update to increment $count so I will fix those as well.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1946805 - Count is not being incremented properly when excluding bugs from the full list and therefore the export script is hanging (#2386)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/7713ff62445daa2b8fd1959d694f7c8b53d21df9