1946823 - Enable Temporal on Nightly

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P1)

Description

[Dan Minor [:dminor]]

To get more feedback on Temporal, I think it would make sense to enable it for Nightly only for a few cycles before we consider shipping it.

Comment 1

[Dan Minor [:dminor]]

I cleared this with the fuzzing team, I think we're good to go here.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1946823 - Enable Temporal in Nightly builds; r=mgaudet!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00105254ffff
Enable Temporal in Nightly builds; r=mgaudet

Comment 4

[Atila Butkovits]

Backed out for causing mass failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c45e218217cfc044de77567110dec0117d5bf588

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=00105254ffff392f3252e48b587eb9b8bd840c4c&selectedTaskRun=a8g9hO9USHqRUk2I5eetsQ.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=493967939&repo=autoland&lineNumber=4583
https://treeherder.mozilla.org/logviewer?job_id=493968822&repo=autoland&lineNumber=2725
https://treeherder.mozilla.org/logviewer?job_id=493964269&repo=autoland&lineNumber=3317
https://treeherder.mozilla.org/logviewer?job_id=493966874&repo=autoland&lineNumber=1815
https://treeherder.mozilla.org/logviewer?job_id=493967718&repo=autoland&lineNumber=70250

Comment 5

[Dan Minor [:dminor]]

Yep, I didn't think about this in terms of shipping a new feature, so I got caught by the usual gotchas that check for exposing something new on the global object. Try job here would indicate that I've caught the problems: https://treeherder.mozilla.org/jobs?repo=try&revision=d03b64ffda2f7dc3daa6ba76736e0a6c2a2113ad.

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1946823 - Adjust test_xrayToJS.html expectations; r=peterv!

Because Temporal.PlainDate.prototype.valueOf is specified to throw,
I've adjusted the stringification tests to check that if an
exception occurs, an identical exception is thrown in both cases.

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1946823 - Adjust interfaces tests to expose Temporal on Nightly only; r=mgaudet!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/707bb5b43e16
Enable Temporal in Nightly builds; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b3e95d718426
Adjust test_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/5e78edce046b
Adjust interfaces tests to expose Temporal on Nightly only; r=mgaudet,webidl,smaug

Comment 9

[Atila Butkovits]

Backed out for causing SM bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/24745a661a79f595fe782a0654b00c53ca69c4d1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5e78edce046b0cda7d498a431d81623fd4cc60f5&selectedTaskRun=I2KlSqLlR8ysM2EZmxBjMw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=494458038&repo=autoland&lineNumber=70719
https://treeherder.mozilla.org/logviewer?job_id=494462985&repo=autoland&lineNumber=2181
https://treeherder.mozilla.org/logviewer?job_id=494467400&repo=autoland&lineNumber=5062

Comment 10

[Dan Minor [:dminor]]

Looks like my mach try auto try run didn't schedule any sm jobs :/

Comment 11

[Dan Minor [:dminor]]

Attachment: Bug 1946823 - Fix multi-header.js skip-if; r=mgaudet!

This is a testcase for test262-export.py, but it is also run as a
normal reftest. For test262-export.py, Temporal tests are skipped
from the export. When run as a reftest with Temporal enabled,
the second part of the condition outro() is evaluated, and it turns
out that outro is undefined. This changes outro to true so
that the test continues to be skipped like before when run as a
reftest.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb50fea050c
Enable Temporal in Nightly builds; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7f3a9b884d88
Adjust test_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/52ee3305de24
Adjust interfaces tests to expose Temporal on Nightly only; r=mgaudet,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/ecdda9773ff1
Fix multi-header.js skip-if; r=mgaudet

Comment 13

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_jsterm_autocomplete_mapped_variables.js

Backout link

Push with failures

Failure log

Comment 14

[Dan Minor [:dminor]]

That test that fails seems unrelated to these changes, and has had a problem with intermittent failures in the past: https://bugzilla.mozilla.org/show_bug.cgi?id=1896759

Comment 15

[Norisz Fay [:noriszfay]]

We've had a try run that confirmed backing out the changesets fixed the perma failures caused here. Taskcluster failure artifacts pointed to Firefox Nightly failures on all affected platforms (temporal was also seen in one artifact that failed on Linux). example: https://firefoxci.taskcluster-artifacts.net/RB8SII9FSH2BeiWE_HYAMQ/0/public/test_info/mozilla-test-fail-screenshot_gfv8znx3.png

Comment 16

[Dan Minor [:dminor]]

Yes, you're correct, the autocomplete will now also suggest Temporal, breaking the test, I missed that the first time I looked at the test case.

Comment 17

[Dan Minor [:dminor]]

Attachment: Bug 1946823 - Add Temporal to browser_jsterm_autocomplete_mapped_variables.js expectations; r=nchevobbe!

Autocomplete will now also suggest Temporal, this adjusts the test
expecations accordingly.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e395ee1a85b7
Enable Temporal in Nightly builds; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/2161091e37ea
Adjust test_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/a892f49ac205
Adjust interfaces tests to expose Temporal on Nightly only; r=mgaudet,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/70f15e233e64
Fix multi-header.js skip-if; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/2e4706ea8f36
Add Temporal to browser_jsterm_autocomplete_mapped_variables.js expectations; r=nchevobbe,devtools-reviewers

Comment 19

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e395ee1a85b7
https://hg.mozilla.org/mozilla-central/rev/2161091e37ea
https://hg.mozilla.org/mozilla-central/rev/a892f49ac205
https://hg.mozilla.org/mozilla-central/rev/70f15e233e64
https://hg.mozilla.org/mozilla-central/rev/2e4706ea8f36

Comment 20

[Pascal Chevrel:pascalc]

That looks like something that could go into our Nightly release notes. Could you nominate it? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla

Comment 21

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Temporal is now enabled by default in Nightly. Temporal is meant to a be better version of Date, which has been a long-standing pain point in the language.
[Affects Firefox for Android]:
[Suggested wording]: The Temporal proposal is enabled by default in Firefox Nightly, please experiment with it and provide feedback. Temporal is a better version of Date, for more details, please see https://tc39.es/proposal-temporal/docs/.
[Links (documentation, blog post, etc)]: https://tc39.es/proposal-temporal/docs/

Comment 22

[Pascal Chevrel:pascalc]

Thanks, added to our nightly notes