1946888 - Retire obsolete sync.totalDevices targeting attribute

Status: NEW

(Firefox :: Messaging System, defect, P2)

Description

[Shane Hughes [:aminomancer]]

Targeting attribute sync returns an object with three properties:

{
  desktopDevices: 1;
  mobileDevices: 1;
  totalDevices: 0;
}

As you can see, totalDevices does not work. It requests the value of a pref that no longer exists.

As far as I can tell, there is no pref tracking the total number of devices. But it's unnecessary to have one, since the total number of devices is simply the number of desktop devices plus the number of mobile devices. We don't need to include a property for that, since the two can be added together with JEXL if necessary: sync.desktopDevices + sync.mobileDevices

Since it's a potential footgun and redundant with the addition operator, I recommend we remove totalDevices and any related references to syncNumDevices and sync.numDevices.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:hanna_a, could you have a look please?

For more information, please visit BugBot documentation.