1947061 - [web-animations] commitStyles always writes the end state of the animation

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Kanaru Sato [:canalun]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36

Steps to reproduce:

change the default behavior of commitStyles based on the discussion; https://github.com/w3c/csswg-drafts/issues/5394

Comment 1

[Kanaru Sato [:canalun]]

Attachment: Bug 1947061 - change commitStyles default behavior. r=birtles

Optionally, a longer description of the change.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Transitions and Animations' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Kanaru Sato [:canalun]]

Attachment: Bug 1947061 - re-order the existing cases of commitStyles. r=birtles

Re-order the existing tests into a logical order.
ref: https://phabricator.services.mozilla.com/D237510

Comment 4

[Kanaru Sato [:canalun]]

Attachment: Bug 1947061 - re-order the existing cases of commitStyles. r=birtles

Re-order the existing tests into a logical order.
ref: https://phabricator.services.mozilla.com/D237510

Comment 5

[Kanaru Sato [:canalun]]

Attachment: Bug 1947061 - add new cases for commitStyles behavior change. r=birtles

Add new cases for changing the default bahavior of commitStyles to
endpoint-inclusive. These cases are now expected to fail because the
spec change is under discussion yet.

Comment 6

[Brian Birtles (:birtles)]

Hi canalun, thanks I think there's just one last nit to address. Have you pushed these patches to try server yet?

When you are ready, can you push to try and run the WPT tests, mochitests, and crashtests on Linux? Hiro can probably give you a better idea of which jobs to choose than I can.

Comment 7

[Kanaru Sato [:canalun]]

ok I will ask Hiro, thanks :)

Now, one of the cases in the second patch still fails...! It's the one we decided to add at the end, "Commits the intermediate value of an animation up to the middle of the stack".
I will look into it and so need a bit more time.

Comment 8

[Kanaru Sato [:canalun]]

and of course I'll fix the last nit, thanks.

Comment 9

[Brian Birtles (:birtles)]

I just started working on the spec PR for this and I realized we also need to take care of the case when the animation is playing backwards. We will need to add tests for that case too.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22c9942e6d31
re-order the existing cases of commitStyles. r=birtles
https://hg.mozilla.org/integration/autoland/rev/8a5bf1a96c03
add new cases for commitStyles behavior change. r=birtles
https://hg.mozilla.org/integration/autoland/rev/28d832f98f08
change commitStyles default behavior. r=birtles,hiro

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51843 for changes under testing/web-platform/tests

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/22c9942e6d31
https://hg.mozilla.org/mozilla-central/rev/8a5bf1a96c03
https://hg.mozilla.org/mozilla-central/rev/28d832f98f08

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot