1947107 - Rename `WhiteSpaceVisibilityKeeper::ReplaceText` because it does not replace text without `CompositionTransaction`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It uses EditorBase::IntertTextWithTransaction() and it replaces composition string if it's called for updating a composition string. So, the name may make developers misunderstood.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1947107 - Rename `WhiteSpaceVisibilityKeeper::ReplaceText` r=m_kato!

Despite the name, it does not replace text of the specified the range.

The range is not collapsed only when updating composition string and even in
the case, EditorBase::InsertTextWithTransaction automatically creates
a CompositionTransaction and the transaction will delete the existing
composition string before inserting the new string.

For making the job of the method clearer, this patch renames it as
InsertOrUpdateCompositionString and it's actually implemented by
InsertTextOrInsertOrUpdateCompositionString.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/518a565d9872
Rename `WhiteSpaceVisibilityKeeper::ReplaceText` r=m_kato

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/518a565d9872