1947454 - [wpt-sync] Sync PR 50628 - Reflect command attribute to known-valid values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50628 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50628
Details from upstream follow.

Keith Cirkel <[e-mail]> wrote:

Reflect command attribute to known-valid values

This changes the reflection rules of the command attribute to match the
spec - https://github.com/whatwg/html/pull/9841. The command attribute
should only reflect known values (or custom ones) and for invalid values
it should return the empty string.

Bug: 394874179
Change-Id: I76d2139762137027961e385250e0976d9395d778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240672
Reviewed-by: Mason Freed \<[e-mail]>
Reviewed-by: Luke \<[e-mail]>
Commit-Queue: Keith Cirkel \<[e-mail]>
Auto-Submit: Keith Cirkel \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1418568}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=08a68418023fb9d84205713705212614a5b2d2d0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 11 subtests

Status Summary

Firefox

OK : 2
PASS: 9
FAIL: 18

Chrome

OK : 2
PASS: 16
FAIL: 11

Safari

OK : 2
PASS: 9
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/the-button-element/command-and-commandfor/command-reflection.tentative.html [wpt.fyi]
  • invoker should reflect odd cased sHoW-MoDaL properly - as show-modal: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect odd cased tOgGlE-pOpOvEr properly - as toggle-popover: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect odd cased hIdE-pOpOvEr properly - as hide-popover: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect odd cased sHoW-pOpOvEr properly - as show-popover: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect odd cased ClOsE properly - as close: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect the invalid value "invalid" as the empty string: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect the invalid value "show-invalid" as the empty string: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoker should reflect the invalid value "foo-bar" as the empty string: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/the-button-element/command-and-commandfor/interface.tentative.html [wpt.fyi]
  • commandForElement reflects invokee HTML element: FAIL (Chrome: PASS, Safari: FAIL)
  • commandForElement reflects set value: FAIL (Chrome: PASS, Safari: FAIL)
  • commandForElement reflects set value across shadow root into light dom: FAIL (Chrome: PASS, Safari: FAIL)
  • commandForElement does not reflect set value inside shadowroot: FAIL (Chrome: PASS, Safari: FAIL)
  • commandForElement throws error on assignment of non Element: FAIL (Chrome: PASS, Safari: FAIL)
  • command reflects '' when attribute empty, setAttribute version: FAIL (Chrome: PASS, Safari: FAIL)
  • command reflects correctly for invalid: FAIL (Chrome: FAIL, Safari: FAIL)
  • command reflects correctly for invalid when array: FAIL (Chrome: FAIL, Safari: FAIL)
  • command reflects '' when attribute set to []: FAIL (Chrome: PASS, Safari: FAIL)
  • command reflects correctly for invalid when object: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f4ff1631320
[wpt PR 50628] - Reflect command attribute to known-valid values, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b1f63aa8b23a
[wpt PR 50628] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7f4ff1631320
https://hg.mozilla.org/mozilla-central/rev/b1f63aa8b23a