Open Bug 1947590 Opened 1 year ago Updated 1 year ago

Colorful horizontal lines in youtube video overlay background gradient due to canvas randomization

Categories

(Core :: Privacy: Anti-Tracking, defect, P3)

Firefox 135
Desktop
All
defect

Tracking

()

Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- affected
firefox135 --- wontfix
firefox136 --- affected
firefox137 --- affected

People

(Reporter: jinra321+bugzilla, Unassigned)

References

(Blocks 2 open bugs, )

Details

Attachments

(3 files)

Attached image lines.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

Watch a youtube video and get the timeline overlay to show up (either by pausing or mousing over the video).

Actual results:

When the timeline/controls overlay shows up, multiple colorful horizontal lines will show up. This is especially visible with darker backgrounds and shows up more on my HDR OLED monitor vs my IPS screens (though still visible on IPS).

Expected results:

No horizontal lines when overlay is shown. Confirmed not an issue on Chrome.

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

Could you please share the contents of your about:support text? Click "copy raw data to clipboard", then paste into a comment here and follow the prompt to upload it as an attachment. Did this behavior occur for you with previous versions of Firefox?

Blocks: yt-playback
Flags: needinfo?(jinra321+bugzilla)
OS: Unspecified → Windows
Hardware: Unspecified → Desktop
Attached file raw support data

(In reply to az [:az] from comment #2)

Could you please share the contents of your about:support text? Click "copy raw data to clipboard", then paste into a comment here and follow the prompt to upload it as an attachment. Did this behavior occur for you with previous versions of Firefox?

I can't recall when it first happened. I suspect it's been around for a little while but haven't really noticed until lately.

Flags: needinfo?(jinra321+bugzilla)

If this used to work in an earlier version of Firefox, please do a bisection to find the exact change that caused this (https://mozilla.github.io/mozregression/)
Finding the regression range would be very useful to help diagnose this issue.

Flags: needinfo?(jinra321+bugzilla)
Duplicate of this bug: 1948507

STR:

  1. Set privacy.resistFingerprinting = true.
  2. Open a youtube video.
  3. Hover the cursor over the video so the controls appear.
  4. Clear cookies and try again if it does not occur.

Expected:
Gradient transition behind controls from partial black transparency to full transparency.

Actual:
Randomization horizontal lines in lower half of video with no transparency gradient.

Issue occurs with FPP targets:

-AllTargets,+CanvasRandomization,+CanvasImageExtractionPrompt,+CanvasExtractionBeforeUserInputIsBlocked
-AllTargets,+CanvasRandomization,+CanvasImageExtractionPrompt
-AllTargets,+CanvasRandomization,+CanvasExtractionBeforeUserInputIsBlocked

Issue does not occur with FPP targets:

+AllTargets,-CanvasRandomization,-CanvasImageExtractionPrompt,-CanvasExtractionBeforeUserInputIsBlocked

Could not reproduce with Strict ETP which only uses +CanvasRandomization (unlike reporter).

Not a regression, reproducible back to version 110.

uBlock Origin workaround (add to "My filters" section):

youtube.com##.ytp-gradient-bottom:style(background-image: linear-gradient(rgba(0,0,0,0), rgba(0,0,0,0.4)) !important;)
Blocks: rfp-breakage
Status: UNCONFIRMED → NEW
Component: Audio/Video: Playback → Privacy: Anti-Tracking
Ever confirmed: true
OS: Windows → All
Summary: Colorful horizontal lines showing up on youtube → Colorful horizontal lines in youtube video overlay background gradient due to canvas randomization

Not a regression, reproducible back to version 110.

Bug 1948507, which you duped to this, is a regression, here's the bisection result for it:

2025-02-16T10:45:26.710000: DEBUG : Found commit message:
Bug 1942648: Support MSign with Int32 input and Double output. r=jandem

Differential Revision: https://phabricator.services.mozilla.com/D234936

2025-02-16T10:45:26.710000: DEBUG : Did not find a branch, checking all integration branches
2025-02-16T10:45:26.712000: INFO : The bisection is done.

Youtube seems to be doing a phased rollout so running mozregression will take you to a random unrelated change.

Can't be sure about the bisection since I only tested once for each build, but my own testing is definitely not random. Bug 1948507 consistently reproduces with 135.0.0 and is consistently fine with 134.0.2

it's been going on for almost 5 years - https://github.com/arkenfox/user.js/issues/924 (back then the RFP canvas was all white)

Duplicate of this bug: 1948556

@Kestral(In reply to Kestrel from comment #10)

I'm not sure this is the same issue, I have privacy.resistantFingerprinting as false, and the issue shown is not quite the same.

Flags: needinfo?(jinra321+bugzilla)
Severity: -- → S3
Priority: -- → P3

I think this is a dupe of Bug 1724663

FWIW YT is aware of this behavior, but because RFP is an unsupported mode I'm not sure they will do anything about it.

See Also: → 1724663

(In reply to Tom Ritter [:tjr] from comment #15)

I think this is a dupe of Bug 1724663

FWIW YT is aware of this behavior, but because RFP is an unsupported mode I'm not sure they will do anything about it.

As mentioned previous, I do not believe this is the same issue. However, since 135.0.1, this seems to be resolved.

Blocks: rfp-canvas-breakage
No longer blocks: rfp-breakage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: