1947613 - Create helpers for using Lit to render elements in test code

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

Starting with the tests for moz_lit_element we have been using Lit to render templates in our chrome tests, rather than the usual method of writing all the HTML markup needed for tests and then writing test code inside the <script> tag. We are doing this in all of our input element tests and our tests for MozBoxButton in addition to in those tests for MozLitElement. We have started to see some repeated logic across these tests - for example this code importing lit and creating a function for rendering templates is fairly similar to this code in our InputTestHelpers class. We should move this functionality somewhere common so that we no longer have to reimplement it each time we want to use Lit in a new test.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1947613 - refactor InputTestHelper functions for generally writing tests using Lit r=#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/247db6ae4912
refactor InputTestHelper functions for generally writing tests using Lit r=reusable-components-reviewers,mstriemer

Comment 3

[amarc]

Backed out for causing mochitest failures @ test_moz_checkbox.html

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_checkbox.html | TypeError: this.renderInputElements is not a function - Should not throw any errors

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a7efcb68798
refactor InputTestHelper functions for generally writing tests using Lit r=reusable-components-reviewers,mstriemer

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1a7efcb68798