Closed Bug 1947678 Opened 3 months ago Closed 1 month ago

"webExtenstion.install" should install web extensions temporary by default and allow a permanent installation as well.

Categories

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
enhancement
Points:
3

Tracking

(firefox138 fixed, firefox139 fixed)

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed
firefox139 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [webdriver:m16][wptsync upstream][webdriver:relnote])

Attachments

(6 files)

Bug 1947678 - [webdriver-client] Allow vendor specific arguments for "webextension.install".
48 bytes, text/x-phabricator-request
Details | Review
Bug 1947678 - [wdspec] Move webextension related fixture to global fixtures.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1947678 - [webdriver-bidi] Install web extensions temporary by default and add "moz:permanent" flag.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1947678 - [webdriver-client] Allow vendor specific arguments for "webextension.install".
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1947678 - [wdspec] Move webextension related fixture to global fixtures.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1947678 - [webdriver-bidi] Install web extensions temporary by default and add "moz:permanent" flag.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

For extension developers who want to test their extensions in the future we will have to support to install them temporarily like what Marionette can already do. So far we didn't agree on getting an extra parameter added to the webExtension.install command in the specification, so maybe we need to add a Mozilla specific one like moz:temporary.

We agreed that we should make the default behavior to install the web extension temporarily. That will allow us to install each kind of web extension even if not signed by default. But that also means that when it should be installed permanently we would require a moz:permanent parameter.

For now I filed https://github.com/w3c/webdriver-bidi/issues/879 to discuss the wanted behavior for WebDriver BiDi. Once it's clear we will know if we need a custom vendor-prefixed argument or if there will be a public one.

Depending on the outcome - and if we cannot correctly describe it in the BiDi specification - we might consider to have some documentation in our firefox-source docs.

URL: https://github.com/w3c/webdriver-bidi...
Summary: Allow "webExtenstion.install" command to install a web extension temporarily → "webExtenstion.install" should install web extensions temporary by default and allow a permanent installation as well.
Duplicate of this bug: 1947684
Blocks: 1950645
Priority: -- → P2
Whiteboard: [webdriver:backlog]
Duplicate of this bug: 1951356

Based on what we saw on bug 1956510 we should switch sooner than later to install temporary by default.

Whiteboard: [webdriver:backlog] → [webdriver:m16]
Blocks: 1956510
Points: --- → 3
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
See Also: → 1957620
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad46c9d74958 [webdriver-client] Allow vendor specific arguments for "webextension.install". r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/917a8f7325bb [wdspec] Move webextension related fixture to global fixtures. r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/dada85be12d0 [webdriver-bidi] Install web extensions temporary by default and add "moz:permanent" flag. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51780 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m16] → [webdriver:m16], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/ad46c9d74958
https://hg.mozilla.org/mozilla-central/rev/917a8f7325bb
https://hg.mozilla.org/mozilla-central/rev/dada85be12d0

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Upstream PR merged by moz-wptsync-bot
See Also: → 1947679

Adding to triage to discuss a potential uplift to 138 beta while it is early in stage.

status-firefox138: --- → fix-optional
Whiteboard: [webdriver:m16], [wptsync upstream] → [webdriver:m16][wptsync upstream][webdriver:triage]

As discussed in the meeting we want to uplift this patch. I'll put up a patch soon.

Whiteboard: [webdriver:m16][wptsync upstream][webdriver:triage] → [webdriver:m16][wptsync upstream]
Attachment #9477483 - Flags: approval-mozilla-beta?
Attachment #9477484 - Flags: approval-mozilla-beta?
Attachment #9477485 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Users of WebDriver are not able to install unsigned and unpacked web extensions
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: None
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Just changes the default value for installing a web extension
  • String changes made/needed: None
  • Is Android affected?: yes
Attachment #9477483 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9477485 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9477484 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [webdriver:m16][wptsync upstream] → [webdriver:m16][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: