1947719 - Move setImportAttributes call out of NIGHTLY_BUILD guard

Status: VERIFIED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Currently, the API to set the import attributes pref is only available in nightly build, see
https://searchfox.org/mozilla-central/rev/5e7382bf8bbb88d8260c72990cfea9b626d9b307/js/xpconnect/src/XPCJSContext.cpp#796,
that causes a problem when running wpt or mochitest in BETA build, even the tests are run with the pref to turn on.

I'll remove the ifdef NIGHTLY_BUILD guard, while still keeping the pref off by default.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1947719 - Part 1: Move import attributes pref and setImportAttributes out of nightly build guard.

Allow the pref could be flipped on/off in beta/release build.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1947719 - Part 2. Update the error message for import attributes.

Replace the legacy name (import assertions) with the correct one (import
attributes).

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1947719 - Part 3: Update WPT ini files and xpcshell config file.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This will fix the failures of bug 1947455 and bug 1947432 on beta release.
https://treeherder.mozilla.org/jobs?repo=try&revision=d2fbe27fad7d22844cde26add8d973d2426978fa

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64a496c34397
Part 1: Move import attributes pref and setImportAttributes out of nightly build guard. r=dminor
https://hg.mozilla.org/integration/autoland/rev/4715f18f59fa
Part 2. Update the error message for import attributes. r=dminor
https://hg.mozilla.org/integration/autoland/rev/48a8dd8caf6e
Part 3: Update WPT ini files and xpcshell config file. r=dminor,extension-reviewers,willdurand
https://hg.mozilla.org/integration/autoland/rev/c9e47dbea687
apply code formatting via Lando

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/64a496c34397
https://hg.mozilla.org/mozilla-central/rev/4715f18f59fa
https://hg.mozilla.org/mozilla-central/rev/48a8dd8caf6e
https://hg.mozilla.org/mozilla-central/rev/c9e47dbea687

Comment 9

[Atila Butkovits]

Verified fixed in today's beta simulation

Comment 10

[Intermittent Failures Robot]

Summary

1 failures in 5022 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

Table

	no_variant
linux1804-64-qr--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1947719&startday=2025-02-10&endday=2025-02-16&tree=all

Comment 11

[Hamish Willee]

I thought this might have something to do with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with, but this particular issue is not linked to https://bugzilla.mozilla.org/show_bug.cgi?id=1736059 (import attributes meta).

Can you tell me what exactly is now supported/changed by this that was not previously? I.e. what needs to be documented/what is the change to data compatibility?