1947741 - “Show all sites”/”Show fewer sites” buttons on install dialog are not very visible when “Dark” theme is enabled

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, defect, P3)

Description

[Alex Cornestean]

Attachment: 6_6_or_more_host_permissions.xpi

Description:

The “Show all sites”/”Show fewer sites” buttons on the install dialog of an extension requesting more than 5 domain permissions is not very visible when the “Dark” theme is enabled. The buttons use a darker shade of purple compared to the rest of the UI, making the buttons not very visible on the dark background. See attached screenshot.

Steps to reproduce:

1. Access about:config and set “extensions.signatures.required” to “false”
2. Access the browser settings and tap on “Customize”. Set the theme to “Dark”
3. Return to the browser settings page, scroll to the bottom and tap on “About Firefox Nightly”
4. Tap the Firefox logo multiple times to enable the secret debug menu
5. Return to the settings page and, under the “Advanced” header tap on the “Install extension from file”
6. Install the attached extension
7. The install dialog is displayed and notice the “Show all sites” button uses a darker shade of purple than the rest of the UI which makes it harder to distinguish from the dark background
8. Tap on the “Show all sites” button and notice the “Show fewer sites” button is displayed, which has the same issue as the “Show all sites” button

Expected results:

The “Show all sites”/”Show fewer sites” buttons should be more visible on the darker background of the install dialog when the “Dark” theme is enabled by using a lighter shade of purple, in line with the rest of the UI.

Actual results:

The “Show all sites”/”Show fewer sites” buttons are not very visible on the darker background of the install dialog when the “Dark” theme is enabled.

Device information

• Firefox version: Nightly (137.0a1-20250211090130)
• Android device model: Oppo Reno 6 5G
• Android OS version: Android 13

Comment 1

[Alex Cornestean]

Attachment: dark_theme_show_button.png

Comment 2

[Rebeca Tudor]

Attachment: Bug 1947741 - Fix dark mode button color extension dialog

The “Show all sites”/”Show fewer sites” buttons on the install dialog
of an extension were displayed only in the light mode color.
To fix the issue, the night color was added.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/922795aea465
Fix dark mode button color extension dialog r=android-reviewers,giorga

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/922795aea465

Comment 5

[Alex Cornestean]

Verified as Fixed. Tested on the latest Fenix Nightly (137.0a1-20250217153514 from https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=749544d5d463ad3bc864266996d264131ebc026e) on an Oppo Reno 6 5G running Android 13.

The “Show all sites”/”Show fewer sites” buttons now use a lighter shade of purple matching the rest of the UI and are now visible on the darker background of the install dialog when the “Dark” theme is enabled. See attached screenshot.

Comment 6

[Alex Cornestean]

Attachment: dark_theme_show_button_fixed.png