Closed
Bug 1947839
Opened 1 year ago
Closed 1 year ago
Newtab medium card cropping is cropping too much
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
137 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr128 | --- | unaffected |
| firefox135 | --- | unaffected |
| firefox136 | --- | unaffected |
| firefox137 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
When we shipped smart cropping, we also fixed the resolution for large cards in sections.
This caused medium cards to crop too much, also for layout variants A and B which are shipped.
So we should probably fix A and B to crop for medium sizes, then sort out cropping for medium and small in sections in another bug.
To test.
- Load newtab.
- Load about:config
- Ensure "browser.newtabpage.activity-stream.newtabLayouts.variant-b" is set to
true
Expected: Right click an image, and select "open image in new tab", the image shown should be a rectangle with the same resolution as a medium card.
Currently: the image when opened in newtab is a square.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Comment 2•1 year ago
|
||
Set release status flags based on info from the regressing bug 1946253
status-firefox135:
--- → unaffected
status-firefox136:
--- → unaffected
status-firefox137:
--- → affected
status-firefox-esr128:
--- → unaffected
Pushed by sdowne@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69316e031026
Newtab fixing image cropping for medium cards r=home-newtab-reviewers,nbarrett
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•