1947868 - [wpt-sync] Sync PR 50663 - [reading-flow] Implement reading-order sorting

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50663 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50663
Details from upstream follow.

Di Zhang <[e-mail]> wrote:

[reading-flow] Implement reading-order sorting

This patch update the Grid and Flex layout algorithm such that the
SetReadingFlowNodes function will sort the reading flow items by the
reading-order int value, after it has already been sorted by
reading-flow value.

Draft spec:
https://drafts.csswg.org/css-display-4/#reading-order

Change-Id: I7d79910c6f017ec6f04cb599b0e04bc45f79ce9f
Bug: 393550130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244985
Commit-Queue: Di Zhang \<[e-mail]>
Reviewed-by: David Grogan \<[e-mail]>
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1419471}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4f8f0da729197152686a42190c8c227b005a122

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL: 5

Chrome

OK : 2
FAIL: 5

Safari

OK : 2
FAIL: 5

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shadow-dom/focus-navigation/reading-flow/tentative/flex-flow.html [wpt.fyi]
  • Flex items in flexbox should follow flex-flow reading flow: FAIL (Chrome: FAIL, Safari: FAIL)
  • Flex items in rtl flexbox should follow flex-flow reading flow: FAIL (Chrome: FAIL, Safari: FAIL)
  • Flex items in vertical-lr flexbox should follow flex-flow reading flow: FAIL (Chrome: FAIL, Safari: FAIL)
• /shadow-dom/focus-navigation/reading-flow/tentative/grid-auto-flow-reading-order.html [wpt.fyi]
  • Grid items should follow grid-rows reading flow, but let reading-order can move item's focus order to the top.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Grid items should follow reading flow, mix of reading-order and order values.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8be6dfb8a40
[wpt PR 50663] - [reading-flow] Implement reading-order sorting, a=testonly
https://hg.mozilla.org/integration/autoland/rev/058c83d08dc4
[wpt PR 50663] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d8be6dfb8a40
https://hg.mozilla.org/mozilla-central/rev/058c83d08dc4