1947900 - [wpt-sync] Sync PR 50668 - Remove focus fixup for removal of `<dialog open>` attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50668 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50668
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Remove focus fixup for removal of <dialog open> attribute

See the conversation here:
https://github.com/whatwg/html/issues/10953#issuecomment-2643608252

This changes the behavior of the DialogCloseWhenOpenRemovedEnabled flag
just a bit, to move toward "option 2" from the comment just below the
one linked above. It also cleans up the two parameters to ::close(),
and replaces them with one. And it stops doing the focus fixup
behaviors in that case.

Bug: 376516550
Change-Id: I072d710df47bbe58f5137070591378c72f8124b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244982
Auto-Submit: Mason Freed \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1419540}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3b45299cc42cb94ba50767132902cace460ffa5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.tentative.html [wpt.fyi]
  • Removing the open attribute from an open modal dialog should run the closing algorithm.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing the open attribute from an open non-modal dialog should fire a close event.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0544e04c6085
[wpt PR 50668] - Remove focus fixup for removal of `<dialog open>` attribute, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0544e04c6085