1948050 - [wpt-sync] Sync PR 50682 - Update collapsible placeholder computation

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50682 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50682
Details from upstream follow.

Utkarsh Pathak <[e-mail]> wrote:

Update collapsible placeholder computation

This CL resolves a crash bug which occurs due to incorrect calculation
as currently we calculate the collapsible placeholder before the call to
|PrepareWhitespaceAtPositionForSplit| method which actually replaces
"\n" with a nbsp and which is why at the time of removal of collapsible
placeholder, it's not there anymore so the DCHECK fails.
Now on, the collapsible placeholder calculation would be done after all
adjustments done on insertion position and just before the node
insertion starts. This makes sure that we check for collapsible
placeholder at correct |insertion_pos|.
The web_test in this CL should not crash.

Bug: 395028747
Change-Id: Ibba1b868da27a0891a5ea8132295acdfacaed641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6248618
Reviewed-by: Sambamurthy Bandaru \<[e-mail]>
Reviewed-by: Kent Tamura \<[e-mail]>
Reviewed-by: Siye Liu \<[e-mail]>
Commit-Queue: Utkarsh Pathak \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1419895}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9d309142d8940bdc24c5b1d1dea089c161216e8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c6561639723
[wpt PR 50682] - Update collapsible placeholder computation, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0c6561639723