Nightly is 3.5x slower in creating hyperlinks on an online Rich Text Editor (https://ckeditor.com/docs/ckeditor5/latest/examples/builds/document-editor.html )
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
People
(Reporter: mayankleoboy1, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
569.17 KB,
text/plain
|
Details |
Go to https://ckeditor.com/docs/ckeditor5/latest/examples/builds/document-editor.html
Delete the existing text in the input-box in the middle
Copy-paste the attached sample text. Wait for it to appear (may take 2-3 seconds)
Download this file to your local machine and open it in some text editor. Then copy-paste its contents on the page.
Select all the pasted text using Ctrl+A
Click on the "Link" button on the toolbar of the Rich Text Editor.
Wait for the popup window of the link to appear.
Nightly: https://share.firefox.dev/4hFZLWI (88s)
Chrome: https://share.firefox.dev/3CKOR2B (25s)
And here is a profile where i actually add a link in the popup : https://share.firefox.dev/41dhMFR
|
||
Comment 1•1 year ago
|
||
A lot of this is overhead for new Set(set). Bug 1935193 would help.
|
||
Updated•1 year ago
|
|
|
||
Comment 2•1 year ago
|
||
I tested this with patches for bug 1935193. It does make this faster, but it's not a huge win because they're cloning large Set objects with 17607 elements (so calling the self-hosted SetConstructorInit function is relatively little overhead in this case) and the sets contain objects which is pretty expensive for us (because we use SipHash).
|
Reporter | |
Comment 3•1 year ago
•
|
||
Profile with Nightly containing the fix fro bug 1935193 : https://share.firefox.dev/4bLhJol (67 seconds) . So a 23% improvement!
And if you focus only on the JS part, the improvement is 27% ! ( Before: 88s, After: 60s)
Description
•