Closed Bug 1948076 Opened 11 days ago Closed 6 days ago

[wpt-sync] Sync PR 50686 - [functions] Support @container within @function

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50686 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50686
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[functions] Support @container within @function

This CL completes the conditional rule support for custom functions,
along with CL:6227574 (@supports) and CL:6234272 (@media).

@container is evaluated more dynamically than the other conditional
at-rules, and therefore the existing invalidation path is sufficient
for functional container queries as well.

Note that ShadowDOM is ignored in this CL; we pass the wrong tree scope
to CQ lookup currently (Issue 394500599). It makes sense to address
this along with tree-scoped lookups of @function rules
(Issue 394111301).

I have also filed two follow-up tasks to avoid mutating MatchResult from
StyleCascade (Issue 394500600), and for renaming HasContainerRelative-
Units to something more accommodating (Issue 394353319).

Bug: 325504770, 394500599, 394111301, 394500600, 394353319
Change-Id: I5cc337562b85f1d5a1561765cf9250fe67f0d6cb
Reviewed-on: https://chromium-review.googlesource.com/6233917
WPT-Export-Revision: 4baaaa1dc379626d144728e2c1efd9ba2a2513d1

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 4
FAIL: 26

Chrome

OK : 4
FAIL: 26

Safari

OK : 4
FAIL: 26

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-mixins/function-conditionals.html [wpt.fyi]
    • Basic @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @supports (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @supports (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Inconsequential conditional: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports with locals: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @media: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @media (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @media: FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @media (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Locals within @media: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports within @media: FAIL (Chrome: FAIL, Safari: FAIL)
    • @media within @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @container: FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic @container (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @container: FAIL (Chrome: FAIL, Safari: FAIL)
    • Nested @container (false): FAIL (Chrome: FAIL, Safari: FAIL)
    • Locals within @container: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports within @container: FAIL (Chrome: FAIL, Safari: FAIL)
    • @container within @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • @container, @media, @supports: FAIL (Chrome: FAIL, Safari: FAIL)
    • @supports, @media, @container: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/function-container-dynamic.html [wpt.fyi]
    • Custom Functions: @container responds to changes: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/function-container-self.html [wpt.fyi]
    • Custom Functions: @container can not query self: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/function-container-style.html [wpt.fyi]
    • Style query on #target should query parent element: FAIL (Chrome: FAIL, Safari: FAIL)
    • Style query on ::before should query originating element: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a664ea832c3 [wpt PR 50686] - [functions] Support @container within @function, a=testonly https://hg.mozilla.org/integration/autoland/rev/126296ffc64d [wpt PR 50686] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4a664ea832c3
https://hg.mozilla.org/mozilla-central/rev/126296ffc64d

Status: NEW → RESOLVED
Closed: 6 days ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.