1948081 - [wpt-sync] Sync PR 50688 - Fix interactive elements in customizable select picker

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50688 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50688
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Fix interactive elements in customizable select picker

MenuListSelectType::DefaultEventHandler has code which may focus the
select element, show/hide the picker, and prevent other default event
handlers from running. This code runs when clicking anything in the
picker since we aren't looking at the event path anymore. This results
in interactive elements not being clickable/focusable in the picker.
This patch fixes this by not running any of this code while the base
appearance picker is open.

This likely stopped working when the PopoverButtonNestingBehavior flag
was used in MenuListSelectType::DefaultEventHandler because the old code
there which no longer gets run would also prevent the
DefaultEventHandler from doing anything in this case.

Change-Id: I5240766badaa0025072bf3123e5dd9f18466de99

Reviewed-on: https://chromium-review.googlesource.com/6240329
WPT-Export-Revision: 955f079bf7dfe75e2b84562f9583740afc3bc426

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9266a72ced2b245742043373529fb3bbb970cca

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
PASS : 2
FAIL : 11

Chrome

OK : 3
PASS : 10
FAIL : 3

Safari

OK : 2
FAIL : 4
ERROR : 1
NOTRUN: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-events.tentative.html [wpt.fyi]
  • Events, implicit button: FAIL (Chrome: FAIL, Safari: FAIL)
  • Events, explicit button: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/customizable-select/select-keyboard-behavior.tentative.html [wpt.fyi]
  • defaultbutton: When the listbox is closed, all arrow keys should open the listbox.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • defaultbutton: When the listbox is closed, the enter key should submit the form or do nothing.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • defaultbutton: When the listbox is open, the enter key should commit the selected option.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • defaultbutton: When the listbox is open, the tab key should close the listbox.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • custombutton: When the listbox is closed, all arrow keys should open the listbox.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • custombutton: When the listbox is closed, the enter key should submit the form or do nothing.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • custombutton: When the listbox is open, the enter key should commit the selected option.: FAIL (Chrome: PASS, Safari: NOTRUN)
  • custombutton: When the listbox is open, the tab key should close the listbox.: FAIL (Chrome: PASS, Safari: NOTRUN)
• /html/semantics/forms/the-select-element/customizable-select/select-picker-interactive-element-focus.tentative.html [wpt.fyi]
  • Clicking interactive elements inside the select picker should focus them.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b82d458a82a8
[wpt PR 50688] - Fix interactive elements in customizable select picker, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f6cd0e7980ff
[wpt PR 50688] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b82d458a82a8
https://hg.mozilla.org/mozilla-central/rev/f6cd0e7980ff