1948093 - [wpt-sync] Sync PR 50691 - LoAF: Add sourceLine and sourceColumn to PerformanceScriptTiming

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50691 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50691
Details from upstream follow.

Joone Hur <[e-mail]> wrote:

LoAF: Add sourceLine and sourceColumn to PerformanceScriptTiming

This CL introduces the sourceLine and sourceColumn properties to the
PerformanceScriptTiming interface. Previously, sourceCharPosition
replaced sourceLine and sourceColumn due to performance reasons:
https://chromium-review.googlesource.com/c/chromium/src/+/4685554

This change allows for more detailed source location information in
PerformanceScriptTiming.

We can enable this feature using the LongAnimationFrameSourceLineColumn
runtime flag:
$ chrome --enable-blink-features=LongAnimationFrameSourceLineColumn

Bug: 391417815
Test:

• web_tests/external/wpt/long-animation-frame/tentative/loaf-source-location.html
  Change-Id: Ie2f99382f3ba96c4e9fd9e696db8c8c36870800d

Reviewed-on: https://chromium-review.googlesource.com/6188741
WPT-Export-Revision: 3ebf091a83f60e094af32da4947fa09cfc72f4f4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=54115c1f8acc03913f0ffc3cae48d63c03e45478

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 3
FAIL : 2

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /long-animation-frame/tentative/loaf-source-location.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

• /long-animation-frame/tentative/loaf-source-location.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/675dd20d4e26
[wpt PR 50691] - LoAF: Add sourceLine and sourceColumn to PerformanceScriptTiming, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/675dd20d4e26