1948094 - Enable calculator by default

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P3)

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 1948094 - Enable calculator by default. r?#urlbar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512f16910756
Enable calculator by default. r=urlbar-reviewers,Standard8

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_providerHeuristicFallback.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fb0c69288bb775e1d84f0052f3623b4797bb1ec7

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js | - Found the expected number of results. - 2 == 1

TEST-START | browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js
[task 2025-02-26T15:21:28.538Z] 15:21:28  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js | xpcshell return code: 0
[task 2025-02-26T15:21:28.541Z] 15:21:28     INFO -  TEST-INFO took 5431ms
[task 2025-02-26T15:21:28.542Z] 15:21:28     INFO -  >>>>>>>
[task 2025-02-26T15:21:28.542Z] 15:21:28     INFO -  PID 23217 | [Parent 23217, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2922
[task 2025-02-26T15:21:28.543Z] 15:21:28     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2025-02-26T15:21:28.544Z] 15:21:28     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2025-02-26T15:21:28.545Z] 15:21:28     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2025-02-26T15:21:28.545Z] 15:21:28     INFO -  running event loop
[task 2025-02-26T15:21:28.545Z] 15:21:28     INFO -  browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js | Starting setup
[task 2025-02-26T15:21:28.545Z] 15:21:28     INFO -  (xpcshell/head.js) | test pending (2)
[task 2025-02-26T15:21:28.546Z] 15:21:28     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2025-02-26T15:21:28.546Z] 15:21:28     INFO -  PID 23217 | [WARN  rkv::backend::impl_safe::environment] `load_ratio()` is irrelevant for this storage backend.
[task 2025-02-26T15:21:28.546Z] 15:21:28     INFO -  "Extension attached"
<...>
"numerical operations that look like urls should search"
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  "Creating new queryContext with searchString: 123/12"
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  "Actual results: [{"type":2,"source":3,"rowIndex":-1,"heuristic":true,"exposureTelemetry":0,"payload":{"engine":"Suggestions","icon":"chrome://global/skin/icons/search-glass.svg","query":"123/12"},"payloadHighlights":{"engine":[],"icon":[],"query":[],"keyword":[]},"providerName":"HeuristicFallback","providerType":1},{"type":8,"source":5,"rowIndex":-1,"heuristic":false,"exposureTelemetry":0,"payload":{"value":10.25,"input":"123/12","dynamicType":"calculator"},"payloadHighlights":{"value":[],"input":[],"dynamicType":[]},"suggestedIndex":1,"providerName":"calculator","providerType":2}]"
[task 2025-02-26T15:21:28.672Z] 15:21:28  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js |  - Found the expected number of results. - 2 == 1
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/urlbar/tests/unit/head.js:check_results:996
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  exiting test
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:869:20
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:981:5
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:70:21
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  equal@resource://testing-common/Assert.sys.mjs:293:8
[task 2025-02-26T15:21:28.672Z] 15:21:28     INFO -  check_results@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/urlbar/tests/unit/head.js:996:10
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  async*@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/urlbar/tests/unit/test_providerHeuristicFallback.js:448:9
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  async*_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1759:22
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1759:38
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  run@/builds/worker/workspace/build/tests/xpcshell/head.js:808:9
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:596:5
[task 2025-02-26T15:21:28.673Z] 15:21:28     INFO -  @-e:1:1
[task 2025-02-26T15:21:28.674Z] 15:21:28     INFO -  exiting test
[task 2025-02-26T15:21:28.674Z] 15:21:28     INFO -  "Force a GC"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429cdb7683c5
Enable calculator by default. r=urlbar-reviewers,Standard8

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/429cdb7683c5

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/429cdb7683c5

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox Nightly 137.0a1 on Windows 10, Ubuntu 22, macOS 14.
Calculator feature is now enabled by default in Firefox Nightly.

Comment 8

[Yazan Al Macki [:yazan]]

Release Note Request
[Why is this notable]: Performing arithmetic calculations is a common browser use case. By supporting this, we are increasing the value of the Suggest section of the address bar.
[Affects Firefox for Android]: No
[Suggested wording]: You can now use the Firefox address bar as a calculator. Simply type in arithmetic expression and view the result in the address bar dropdown. Clicking on this result will copy it to your clipboard.
[Links (documentation, blog post, etc)]:

Comment 9

[Pascal Chevrel:pascalc]

Note added to our 137 beta notes. I am keeping the release note flag open until we ship it to the release channel, thanks.

2025-03-17 Update: typo fix, added screenshot, marked as a progressive rollout