1948143 - Make Suggest's DEFAULT_PREFS and related code easier to understand and modify

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

UI_PREFS_BY_VARIABLE should always be a subset of DEFAULT_PREFS, but since they're separate properties, that's not obvious. I'd like to have a single structure that lists all the core Suggest prefs along with their defaults and whether they're exposed in the settings UI. I'd also like to perform runtime validation on it. Failing validation will/should be caught by tests.

Also, Daisuke mentioned that DEFAULT_PREFS and UI_PREFS_BY_VARIABLE aren't very clear as names because there are so many other Suggest prefs, so we should try to use clearer name(s) too.

Comment 1

[Drew Willcoxon :adw]

Daisuke suggests using shouldEnable in the name. It's a good idea. Oops, no I think I misunderstood that comment. But still, "should enable" or "to enable" isn't a bad idea.