Closed Bug 1948143 Opened 1 year ago Closed 11 months ago

Make Suggest's DEFAULT_PREFS and related code easier to understand and modify

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox140 --- fixed

People

(Reporter: adw, Unassigned)

References

Details

(Whiteboard: [sng])

UI_PREFS_BY_VARIABLE should always be a subset of DEFAULT_PREFS, but since they're separate properties, that's not obvious. I'd like to have a single structure that lists all the core Suggest prefs along with their defaults and whether they're exposed in the settings UI. I'd also like to perform runtime validation on it. Failing validation will/should be caught by tests.

Also, Daisuke mentioned that DEFAULT_PREFS and UI_PREFS_BY_VARIABLE aren't very clear as names because there are so many other Suggest prefs, so we should try to use clearer name(s) too.

Daisuke suggests using shouldEnable in the name. It's a good idea. Oops, no I think I misunderstood that comment. But still, "should enable" or "to enable" isn't a bad idea.

I fixed this in bug 1966811.

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox140: --- → fixed
Depends on: 1966811
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
QA Whiteboard: [qa-triage-done-c141/b140]
You need to log in before you can comment on or make changes to this bug.