1948254 - Implement #navigate-event-firing

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Andreas Farre [:farre] (PTO -> Dec 7th)]

Implement #navigate-event-firing

Comment 1

[Andreas Farre [:farre] (PTO -> Dec 7th)]

Attachment: Bug 1948254 - Part 1: Implement WebIDL #wait-for-all. r=smaug!,peterv!,saschanaz!

Add an alternative for Promise::All that doesn't create a final promise,
and that restricts the amount of microtasks further. This algorithm is
defined in the WebIDL spec, and is used by #navigate-event-firing from
the Navigation API.

Also add ImplCycleCollectionTrace to make it possible to configure the
NS_IMPL_CYCLE_COLLECTION_TRACE_JS_MEMBER_CALLBACK step and trace
containers of traceable objects, much like ImplCycleCollectionTraverse.

Comment 2

[Andreas Farre [:farre] (PTO -> Dec 7th)]

Attachment: Bug 1948254 - Part 4: Implement #navigate-event-firing. r=#dom-core!

This includes:

• #fire-a-traverse-navigate-event
• #fire-a-push/replace/reload-navigate-event
• #fire-a-download-request-navigate-event

which are all implemented in terms of #inner-navigate-event-firing-algorithm.

Actually calling any of the above is only added for History.pushState and
History.replaceState using #fire-a-push/replace/reload-navigate-event.

Comment 5

[Andreas Farre [:farre] (PTO -> Dec 7th)]

Attachment: Bug 1948254 - Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv!

This makes UniquePtr<T> and nsTHashtable<T> use
ImplCycleCollectionContainer which removes the need of writing dedicated
specializations for the combination of these types.

This also fixes an issue with ImplCycleCollectionContainer for const
fields.

Comment 6

[Andreas Farre [:farre] (PTO -> Dec 7th)]

Attachment: Bug 1948254 - Part 3: Fix DOMEventTargetHelper creation. r=smaug!

Also fix getters protocol usage and add asserts when null returning
getters actually have been checked implicitly.

Also add spec links and shorten multipage to single page links.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c4be02a9115
Part 1: Implement WebIDL #wait-for-all. r=smaug,saschanaz
https://hg.mozilla.org/integration/autoland/rev/d13b8e53fb78
Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv
https://hg.mozilla.org/integration/autoland/rev/e327d067c6a0
Part 3: Fix DOMEventTargetHelper creation. r=smaug
https://hg.mozilla.org/integration/autoland/rev/14269121caf3
Part 4: Implement #navigate-event-firing. r=webidl,smaug

Comment 8

[amarc]

Backed out for causing build bustages @ NavigateEvent.h

• Backout link

• Push with failures

• Failure Log

• Wpt failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f3acb6cf9cd
Part 1: Implement WebIDL #wait-for-all. r=smaug,saschanaz
https://hg.mozilla.org/integration/autoland/rev/05bbdc23154a
Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv
https://hg.mozilla.org/integration/autoland/rev/403e2c469af4
Part 3: Fix DOMEventTargetHelper creation. r=smaug
https://hg.mozilla.org/integration/autoland/rev/545c51e30bd9
Part 4: Implement #navigate-event-firing. r=webidl,smaug

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing failure on idlharness.https.html

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a26e79ce32e
Part 1: Implement WebIDL #wait-for-all. r=smaug,saschanaz
https://hg.mozilla.org/integration/autoland/rev/a79c8bef5dc3
Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv
https://hg.mozilla.org/integration/autoland/rev/640382d73264
Part 3: Fix DOMEventTargetHelper creation. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f5ad49e89bc3
Part 4: Implement #navigate-event-firing. r=webidl,smaug

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing wpt & hazard failures @ Navigation.cpp / NavigateEvent

Backout link: https://hg.mozilla.org/integration/autoland/rev/c5aa316c6d0b05272e31372a8109b11d56e5a4b6

Push with failures

Failure log hazard

Failure log wpt

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de134481ec47
Part 1: Implement WebIDL #wait-for-all. r=smaug,saschanaz
https://hg.mozilla.org/integration/autoland/rev/763b0331c48b
Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv
https://hg.mozilla.org/integration/autoland/rev/7061817d6823
Part 3: Fix DOMEventTargetHelper creation. r=smaug
https://hg.mozilla.org/integration/autoland/rev/98ba043125fe
Part 4: Implement #navigate-event-firing. r=webidl,smaug,jjaschke

Comment 14

[amarc]

Backed out for causing hazard bustage @ Navigation.cpp

• Backout link
• Push with failures
• Failure Log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6be8bbf1c192
Part 1: Implement WebIDL #wait-for-all. r=smaug,saschanaz
https://hg.mozilla.org/integration/autoland/rev/aa744a2148b8
Part 2: Use ImplCycleCollectionContainer for more containers. r=peterv
https://hg.mozilla.org/integration/autoland/rev/5ef6c80fec67
Part 3: Fix DOMEventTargetHelper creation. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9e352a9fb997
Part 4: Implement #navigate-event-firing. r=webidl,smaug,jjaschke

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6be8bbf1c192
https://hg.mozilla.org/mozilla-central/rev/aa744a2148b8
https://hg.mozilla.org/mozilla-central/rev/5ef6c80fec67
https://hg.mozilla.org/mozilla-central/rev/9e352a9fb997