1948347 - Developer console timestamp only shows time, not date

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Dr B W Darvell]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

Open Error Console, Show Timestamp is on.

Actual results:

Only clock time shows.

Expected results:

Date should be prepended.
If TB is active for a long period (mine can be for many days), it is not possible to work out when something happened.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Would it be enough to put the date as a title of the timestamp? Or I guess we could try to only display the full date when the message was emitted another day than the current one, so we wouldn't waste too much space in the most common case.

The timestamp is rendered in https://searchfox.org/mozilla-release/rev/0b40e2935f3edfdd97e9d1a0b70dd87b9137248d/devtools/client/webconsole/components/Output/Message.js#213-224

renderTimestamp() {
  if (!this.props.timestampsVisible) {
    return null;
  }

  return dom.span(
    {
      className: "timestamp devtools-monospace",
    },
    l10n.timestampString(this.props.timeStamp || Date.now())
  );
}

Comment 2

[Dr B W Darvell]

Inserting the date just at or after midnight on its own line would make it clear, it does not have to be on every line.
(Sorry, I am not familiar with the coding, cannot comment.)

Comment 3

[Joshua O'Brien]

Putting the date as the title sounds like a good approach to me. I'd be happy to work on this.

Comment 4

[Dr B W Darvell]

VG

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Joshua O'Brien from comment #3)

Putting the date as the title sounds like a good approach to me. I'd be happy to work on this.

Great, thanks Joshua! I assigned the bug to you.

If you didn't already, you can go through https://firefox-source-docs.mozilla.org/devtools/index.html to setup the work environment.
Ask any question you have here or on https://chat.mozilla.org/#/room/#devtools:mozilla.org if you want to chat

Comment 6

[Joshua O'Brien]

Attachment: Bug 1948347 - Add date title to timestamps in developer console. r=nchevobbe

Comment 7

[Dr B W Darvell]

As an aside, I see no problem with ISO date format because it is logical, unambiguous, and consistent with numerical formatting, i.e. decreasing value to the right, as in ordinary decimal format: YYYYMMDDHHMMSS.sss (with or without hyphens)
Universal hard-coded would make sense.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adb112ec3998
Add date title to timestamps in developer console. r=nchevobbe,devtools-reviewers

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/adb112ec3998

Comment 10

[Dr B W Darvell]

Thanks all - I look forward to seeing that.