Closed Bug 1948415 Opened 9 months ago Closed 18 days ago

Create a page header component

Categories

(Toolkit :: UI Widgets, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
146 Branch
Tracking Status
firefox146 --- fixed

People

(Reporter: mstriemer, Assigned: hjones)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

We'll need a page header component for our Settings Redesign, and this could be reused across other in-content pages. It should require a heading, and allow for an icon, description, support link, breadcrumbs and back button.

This is quite similar to the input base class, but with a heading instead of a span for the label. We could eventually share some layout code, but probably best to make a new thing here to start.

https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=697-14848&t=6MxwIGRLwtwSHA0h-4

Whiteboard: [recomp]
Assignee: nobody → hjones
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cac284bf0e4f https://hg.mozilla.org/integration/autoland/rev/1c2212abab36 Create a moz-page-header component r=fluent-reviewers,desktop-theme-reviewers,mstriemer,bolsson,dao
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/00a4d600c1e6 https://hg.mozilla.org/integration/autoland/rev/954264ae826d Revert "Bug 1948415 - Create a moz-page-header component r=fluent-reviewers,desktop-theme-reviewers,mstriemer,bolsson,dao" for causing mochitest failures @ test_moz_page_header.html This reverts commit cac284bf0e4f2efe788cad7757eeeee4b23c6b8d.

Backed out for causing mochitest failures @ test_moz_page_header.html

Flags: needinfo?(hjones)
Status: ASSIGNED → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 146 Branch → ---
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f078c3f2cd6c https://hg.mozilla.org/integration/autoland/rev/343e52838ae3 Create a moz-page-header component r=fluent-reviewers,desktop-theme-reviewers,mstriemer,bolsson,dao
Flags: needinfo?(hjones)
Status: REOPENED → RESOLVED
Closed: 19 days ago18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Duplicate of this bug: 1948981
Regressions: 1997197
QA Whiteboard: [qa-triage-done-c147/b146]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: