Closed Bug 1948607 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 50738 - Fix <select> GetListItems crash

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50738 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50738
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Fix <select> GetListItems crash

GetListItems is supposed to track descendant \<optgroup> elements, but
the code which invalidates GetListItems was only looking for a parent
\<select> element when the \<optgroup> is inserted instead of any ancestor
\<select>.

Fixed: 396475564
Change-Id: I905cf88542e3a01a77364f11bae023ec2a2a6ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6270416
Auto-Submit: Joey Arhar \<jarhar@chromium.org>
Reviewed-by: Traian Captan \<tcaptan@chromium.org>
Commit-Queue: Traian Captan \<tcaptan@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1420785}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

Chrome

PASS : 1

Safari

TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b3c9f28513a [wpt PR 50738] - Fix <select> GetListItems crash, a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.