1948704 - Better error messages for Temporal parser

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P2)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1948704 - Part 1: Improve error message for missing duration unit designator. r=dminor!

Improves the error message for Temporal.Duration.from("P1")
from:
"RangeError: unexpected garbage after end of input"
to:
"RangeError: missing duration unit designator"

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1948704 - Part 2: Track error for largest valid prefix. r=dminor!

Improves the error message when multiple parse goals are tried.

For example Temporal.PlainTime.from("10:00Z") reported:
"RangeError: missing four digit year"
but is now reporting:
"RangeError: unexpected UTC designator 'Z'"

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1948704 - Part 3: Rename error for extra characters at end of string. r=dminor!

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1948704 - Part 4: Add parse goal to error message. r=dminor!

Improve the error message to indicate there was an error while parsing a
string. And add the parse goal to give a hint how the string was parsed.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1948704 - Part 5: Add error for empty strings. r=dminor!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f922ad21c6
Part 1: Improve error message for missing duration unit designator. r=dminor
https://hg.mozilla.org/integration/autoland/rev/1e6ac0d665fd
Part 2: Track error for largest valid prefix. r=dminor
https://hg.mozilla.org/integration/autoland/rev/a3a22dde7373
Part 3: Rename error for extra characters at end of string. r=dminor
https://hg.mozilla.org/integration/autoland/rev/94ea0a0d0a5c
Part 4: Add parse goal to error message. r=dminor
https://hg.mozilla.org/integration/autoland/rev/28c0017a7853
Part 5: Add error for empty strings. r=dminor

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c6f922ad21c6
https://hg.mozilla.org/mozilla-central/rev/1e6ac0d665fd
https://hg.mozilla.org/mozilla-central/rev/a3a22dde7373
https://hg.mozilla.org/mozilla-central/rev/94ea0a0d0a5c
https://hg.mozilla.org/mozilla-central/rev/28c0017a7853