1948719 - Bump up string cropLimit in JSONViewer

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

The limit is at 50 now https://searchfox.org/mozilla-release/rev/0b40e2935f3edfdd97e9d1a0b70dd87b9137248d/devtools/client/jsonview/components/JsonPanel.js#100-102,105,107

  return Rep(
    Object.assign({}, props, {
      cropLimit: 50,
...
    })
...
}

WE have plenty of room in the JSONViewer, so we can bump that quite a bit to save clicks

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1948719 - [devtools] Bump up string crop limit in JSON Viewer. r=#devtools.

The string length limit was done in 2 places:

• when creating the Rep, with the cropLimit prop
• but it was also hardcoded in the TreeView in isLongString

So here we bump up cropLimit, and we add a new maxStringLength
prop to the TreeView that will control the length at which
a given string should get a twisty.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee1ffe0a80eb
[devtools] Bump up string crop limit in JSON Viewer. r=devtools-reviewers,jdescottes.

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ee1ffe0a80eb