1948727 - Users can reopen the same tabs twice from the List all tabs menu as well as from Recently Closed Tabs menu

Status: NEW

(Firefox :: Session Restore, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: Screencast from 2025-02-17 17-14-05.webm

Found in

• Nightly 137.0a1 (2025-02-17)

Affected versions

• Nightly 137.0a1 (2025-02-17)
• Beta 136.0b6

Affected platforms

• All

Steps to reproduce

1. Have 2 free Tabs.
2. Create a separate Tab Group with Wikipedia, Facebook and Reddit websites.
3. Right click on one of the free tabs and select Close other tabs from the Context menu.
4. Open the list all tabs menu and Select the Previously closed Tab group.
5. Reach History > Recently Closed Tabs and Reopen all tabs.

Expected result

• Opening the Tab group from the list all tabs menu should reopen all tabs from the Tab group.
  History > Recently Closed Tabs should only show the Free Tab that was previously closed since The other Closed Tabs have already been restored from the list all tabs menu.

Actual result

• Sometimes Restoring a Tab group from the list all tabs menu does not restore all tabs.
  When the Tab group is restored and the user reaches History > Recently Closed Tabs he will notice the Tabs are still displayed there and he is able to restore them to the same group again duplicating tabs.
  Sometimes some of the tabs from the recently closed tab are not restored to the Tab group but instead they are restored as Free tabs.

The following error is displayed in Browser Console:

error while calling asyncPermitUnload Error: permitUnload is already running for this tab.
asyncPermitUnload chrome://global/content/elements/browser-custom-element.js:1757
_startRemoveTabs chrome://browser/content/tabbrowser/tabbrowser.js:4232
removeTabs chrome://browser/content/tabbrowser/tabbrowser.js:4402
removeTabGroup chrome://browser/content/tabbrowser/tabbrowser.js:2985
_startRemoveTabs chrome://browser/content/tabbrowser/tabbrowser.js:4283
removeTabs chrome://browser/content/tabbrowser/tabbrowser.js:4402
removeAllTabsBut chrome://browser/content/tabbrowser/tabbrowser.js:4124
<anonymous> chrome://browser/content/main-popupset.js:96
tabbrowser.js:4258:25
_startRemoveTabs chrome://browser/content/tabbrowser/tabbrowser.js:4258
removeTabs chrome://browser/content/tabbrowser/tabbrowser.js:4418
removeTabGroup chrome://browser/content/tabbrowser/tabbrowser.js:2985
_startRemoveTabs chrome://browser/content/tabbrowser/tabbrowser.js:4283
removeTabs chrome://browser/content/tabbrowser/tabbrowser.js:4402
removeAllTabsBut chrome://browser/content/tabbrowser/tabbrowser.js:4124
<anonymous> chrome://browser/content/main-popupset.js:96

Regression range
Not a regression.