Closed
Bug 1948738
Opened 1 year ago
Closed 10 months ago
[composable toolbar] Configure showing a reader mode button
Categories
(Firefox for Android :: Toolbar, task, P2)
Tracking
()
RESOLVED
FIXED
141 Branch
| Tracking | Status | |
|---|---|---|
| firefox141 | --- | fixed |
People
(Reporter: petru, Assigned: petru)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fxdroid][group3][composable toolbar])
Attachments
(2 files)
Configure showing / hiding the reader mode button.
Currently the button is added here and then shown/hidden from ReaderViewFeature.
We should also update the tint of the button when it is clicked.
This is currently handled through dispatches of UpdateReaderActiveAction.
|
Assignee | |
Updated•1 year ago
|
Whiteboard: [ → [fxdroid][group3][composable toolbar]
|
||
Updated•1 year ago
|
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Updated•10 months ago
|
Assignee: nobody → petru
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 months ago
|
||
|
|
Assignee | |
Comment 2•10 months ago
|
||
Pushed by plingurar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/84f69a8ad945
https://hg.mozilla.org/integration/autoland/rev/eeade9aa5f78
part 1 - Configure updating BrowserScreenState with reader mode status r=android-reviewers,harrisono
https://github.com/mozilla-firefox/firefox/commit/a5a179143ead
https://hg.mozilla.org/integration/autoland/rev/f2f683affde4
part 2 - Configure showing reader mode controls in the composable toolbar r=android-reviewers,pollymce
|
||
Comment 4•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eeade9aa5f78
https://hg.mozilla.org/mozilla-central/rev/f2f683affde4
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox141:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•