1948761 - [composable toolbar] Configure the QR scan button

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Petru-Mugurel Lingurar [:petru]]

Similar to the current functionality we should add a button to allow entering scanning a link to access when in edit mode.

Since the QR scanning functionality is outside of the toolbar composable we should use the AppStore to put the application in the "need QR scanning" mode and then have the toolbar middleware consume the identified url from AppState

As a new development, this button should not be shown for Android automotive, see bug 1964497.

Comment 1

[[:harrisono]]

Attachment: Bug 1948761 - Part 1: Add QrScanner actions, state and binding r=#android-reviewers

Depends on D254893

Comment 2

[[:harrisono]]

Attachment: Bug 1948761 - Part 2: Add camera permission flow to QrScannerDelegate and HomeActivity for QR scanner in toolbar r=#android-reviewers

Comment 3

[[:harrisono]]

Attachment: Bug 1948761 - Part 3: Add open other app intents to QrScannerDelegate r=#android-reviewers

Depends on D255184

Comment 4

[[:harrisono]]

Attachment: Bug 1948761 - Part 4: fix QrFragment back handling for API 33+

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948761 - Add a View.handleBackEvents method to allow more easily intercept back buttons/gestures r=#android-reviewers

This is very similar to the BackHandler from Jetpack Compose but will work with any Views.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72e70bf40a50
https://hg.mozilla.org/integration/autoland/rev/8ba3d2ccb4ef
Add a View.handleBackEvents method to allow more easily intercept back buttons/gestures r=android-reviewers,harrisono

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8ba3d2ccb4ef

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dfe20089558f
https://hg.mozilla.org/integration/autoland/rev/5881d1b71ac1
Part 1: Add QrScanner actions, state and binding r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/0f7a739bea5b
https://hg.mozilla.org/integration/autoland/rev/5dde9bb11536
Part 2: Add camera permission flow to QrScannerDelegate and HomeActivity for QR scanner in toolbar r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/76ed8db8706d
https://hg.mozilla.org/integration/autoland/rev/136ad9652457
Part 3: Add open other app intents to QrScannerDelegate r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/bca9e9d5fd7a
https://hg.mozilla.org/integration/autoland/rev/f418c31e37f6
Part 4: fix QrFragment back handling for API 33+ r=android-reviewers,petru

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5881d1b71ac1
https://hg.mozilla.org/mozilla-central/rev/5dde9bb11536
https://hg.mozilla.org/mozilla-central/rev/136ad9652457
https://hg.mozilla.org/mozilla-central/rev/f418c31e37f6