1948764 - [composable toolbar] Configure autocomplete

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Similarly to the current functionality we should allow configuring the autocomplete functionality when in edit mode.

This does not imply refactoring InlineAutocompleteEditText to a composable.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948764 - part 1 - Configure the UI for searching in the composable toolbar r=#android-reviewers

Matching configuration from mozac_browser_toolbar_edittoolbar configuration
and ToolbarView which previously set the colors to use.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948764 - part 2 - Configure the UX for searching in the composable toolbar r=#android-reviewers

Whenever the search query or the autocomplete providers are updated the
toolbar will automatically query the autocomplete providers for url
suggestions that start with the current query and display them inline
with the current query but with a different text background.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948764 - part 3 - Keep autocomplete suggestion while search suggestions are shown r=#android-reviewers

Users can swipe on the search suggestions list to hide the keyboard.
By keeping the toolbar focused the autocomplete suggestion will remain
displayed.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948764 - part 3 - Ensure synchronous store updates when updating the search toolbar r=#android-reviewers

Observed with manual testing that sometimes the search selector or the
autocomplete would not behave as expected.
Seems like this was happening because middleware.context.store.dispatch
will update the store asynchronously while middleware.context.dispatch
will block until the action has gone through the reducer and all the
registered middlewares ensuring that later actions/store updates will
see the up-to-date state instead of potentially an older state.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8d3f74d80d68
https://hg.mozilla.org/integration/autoland/rev/b26bdacbf415
part 1 - Configure the UI for searching in the composable toolbar r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/3105f3abf303
https://hg.mozilla.org/integration/autoland/rev/daf30d9dbadd
part 2 - Configure the UX for searching in the composable toolbar r=android-reviewers,Roger

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b26bdacbf415
https://hg.mozilla.org/mozilla-central/rev/daf30d9dbadd