1948876 - Fix NEL implementation and WPT tests

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Our NEL implementation currently passes all the WPT tests, but we had a few hacks in it just to pass the tests.
This bug is to address the test issues where they disagree with the spec.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1948876 - Fix sends-report-on-subdomain-dns-failure.https.html NEL test to use no-path-and-query URL r=#necko

https://www.w3.org/TR/2023/WD-network-error-logging-20231005/#deliver-a-network-report
3. If report body's phase property is dns or connection:
Clear url's path and query.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1948876 - NEL: Do not submit method and status code if phase is dns r=#necko

https://www.w3.org/TR/2023/WD-network-error-logging-20231005/#generate-a-network-error-report
8. If report body's phase property is not dns or connection, append the following properties to report body:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/943aa0d92519
Fix sends-report-on-subdomain-dns-failure.https.html NEL test to use no-path-and-query URL r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/bb7ae8f61276
NEL: Do not submit method and status code if phase is dns r=necko-reviewers,kershaw

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50822 for changes under testing/web-platform/tests

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/943aa0d92519
https://hg.mozilla.org/mozilla-central/rev/bb7ae8f61276

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot