1949286 - The "Add new signature" button is not localized in RTL builds

Status: RESOLVED INVALID

(Firefox :: PDF Viewer, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: RTL.png

Found in Version:

• 137.0a1

Affected Versions:

• 137.0a1

Tested Platforms:

• Affected: Windows, Ubuntu, Mac
• Unaffected: None

Preconditions:

• Make sure to have pdfjs.enableSignatureEditor set to true
• An RTL build is used (e.g. Arabic or Hebrew).

Steps to reproduce:

1. Open a PDF file.
2. Click on the Signature icon in the toolbar to open the signature doorhanger.
3. Observe the "Add New Signature" button.

Expected Result:

• The "Add new signature" button should be localized like the other buttons in the Signature modal.

Actual Result:

• The "Add new signature" button remains in English, while other elements in the Signature modal are correctly localized.

Regression Range:

• Not a regression, as the feature was recently implemented.

Attachments:

• Screenshot showing the issue

Comment 1

[Calixte Denizet (:calixte)]

The string is translated in Arabic:
https://pontoon.mozilla.org/ar/firefox/toolkit/toolkit/pdfviewer/viewer.ftl/?search=Add+new+signature&string=315636

So we should have it in nightly soon I guess.
:flod, could you confirm we can safely close this bug ?

Comment 2

[Francesco Lodolo [:flod]]

In general, this type of bug is invalid (locales catch up at different speed, that's part of the system).

Comment 3

[Francesco Lodolo [:flod]]

Also, noting that this string was exposed 2 days ago, no locale is expected to have it translated (maybe Italian, depending on my availability).