1949363 - Crash in [@ mozilla::layers::NativeLayerRootWayland::Shutdown]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P5)

Description

[GreyXor]

Crash report: https://crash-stats.mozilla.org/report/index/5cdc4aa3-2c69-4f77-a853-f478d0250220

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(!mSurface->IsMapped()) (Can't shutdown with live WaylandSurface!)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:263
0  libxul.so  mozilla::layers::NativeLayerRootWayland::Shutdown()  gfx/layers/NativeLayerWayland.cpp:185
1  libxul.so  mozilla::widget::GtkCompositorWidget::~GtkCompositorWidget()  widget/gtk/GtkCompositorWidget.cpp:60
2  libxul.so  mozilla::widget::InProcessGtkCompositorWidget::~InProcessGtkCompositorWidget()  widget/gtk/InProcessGtkCompositorWidget.h:16
3  libxul.so  mozilla::widget::CompositorWidget::Release()  widget/CompositorWidget.h:90
3  libxul.so  mozilla::RefPtrTraits<mozilla::widget::CompositorWidget>::Release(mozilla::wi...  mfbt/RefPtr.h:49
3  libxul.so  RefPtr<mozilla::widget::CompositorWidget>::ConstRemovingRefPtrTraits<mozilla:...  mfbt/RefPtr.h:409
3  libxul.so  RefPtr<mozilla::widget::CompositorWidget>::assign_assuming_AddRef(mozilla::wi...  mfbt/RefPtr.h:68
3  libxul.so  RefPtr<mozilla::widget::CompositorWidget>::operator=(std::nullptr_t)  mfbt/RefPtr.h:180
3  libxul.so  mozilla::layers::InProcessCompositorSession::Shutdown()  gfx/ipc/InProcessCompositorSession.cpp:103

Comment 1

[GreyXor]

https://bugzilla.mozilla.org/show_bug.cgi?id=1938033

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Disabled by default.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1949363 [Wayland] Allow to remove NativeLayerRootWayland from live WaylandSurface r?emilio

It's possible that compositor widget is deleted before WaylandSurface is fully unmapped so clear WaylandSurface in such case.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938033

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21b841b3fc24
[Wayland] Allow to remove NativeLayerRootWayland from live WaylandSurface r=emilio

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/21b841b3fc24

Comment 7

[GreyXor]

I confirm this crash doesn't happen anymore, thanks