1949453 - Crash reporter does not correctly convert the AsyncShutdownTimeout field when creating the Glean ping

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Alex Franchuk [:afranchuk]]

The field is a string with JSON data, however the code assumes it is already a deserialized json object. A single, centralized code path for extra file creation and ping creation would have easily avoided this issue (bug 1911301).

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1949453 - Correctly interpret the AsyncShutdownTimeout annotation when creating the Glean ping r=gsvelto

Previously the code assumed it was already a deserialized object,
however it is a string that needs to be deserialized.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a977fef53ddd
Correctly interpret the AsyncShutdownTimeout annotation when creating the Glean ping r=gsvelto

Comment 3

[Atila Butkovits]

Backed out for causing bustages complainin about crashreporter.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ed2773e25af01b0dec9920cf85ab0e8fdd820c8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a977fef53ddd5fecd9488a22a1c31ff38c40407e&selectedTaskRun=Ll_seEJZRISiQtrlXTfaHg.0

Failure log: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a977fef53ddd5fecd9488a22a1c31ff38c40407e&selectedTaskRun=Ll_seEJZRISiQtrlXTfaHg.0

Comment 4

[Alex Franchuk [:afranchuk]]

Huh, I didn't see those tests failing when I ran it locally (and I definitely ran it since I had to update the tests to ensure things passed). Not sure what happened there, but I assume it'll be a simple reproduction and fix.

Comment 5

[Alex Franchuk [:afranchuk]]

Weirdest thing; I'm actually not able to reproduce the failures. There's really not much that depends on e.g. the environment in those tests.

Comment 6

[Alex Franchuk [:afranchuk]]

Oh, it looks like I had a local change and forgot to update the patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0af7a39fb3e1
Correctly interpret the AsyncShutdownTimeout annotation when creating the Glean ping r=gsvelto

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/0af7a39fb3e1