1949460 - Remove jszip library from devtools

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1929387 is going to land duplicates of React modules as ESM. We will later remove the non-ESM builds, but in the meantime, we should try to cleanup the unnecessary cruft from DevTools.
It is only used by Har Exporter and could instead use nsIZipWriter.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1949460 - [devtools] Remove jszip library from devtools.

We could use the built-in ZipWriter component instead.

This also prevent naming the file within the zip file with a zip extension,
which makes things really confusing!

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1949460 - [devtools] Remove jszip library from devtools.

We could use the built-in ZipWriter component instead.

This also prevent naming the file within the zip file with a zip extension,
which makes things really confusing!

Comment 3

[Julian Descottes [:jdescottes]]

Hi Peter, I am not sure if browsertime is still using DevTools to record HAR files for Firefox in some situations, but it looks like this patch would change the structure of the ZIP file generated. Let us know if you need help to migrate.

Comment 4

[Peter Hedenskog]

Hi Julian, thank you for reaching out! No we use only the new bidi-har now so it will not affect Browsertime.

Comment 5

[Julian Descottes [:jdescottes]]

(In reply to Peter Hedenskog from comment #4)

Hi Julian, thank you for reaching out! No we use only the new bidi-har now so it will not affect Browsertime.

That's great to hear, both for BiDi and for this issue, thanks for checking :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3be3142d3aed
[devtools] Remove jszip library from devtools. r=devtools-reviewers,sylvestre,nchevobbe

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3be3142d3aed

Comment 8

[Mayank Bansal]

Reduced the installer size on Windows by 88KB!

Comment 9

[Alex Finder]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3be3142d3aed
[devtools] Remove jszip library from devtools.
r=devtools-reviewers,sylvestre,nchevobbe

Perfherder has detected a build_metrics performance change from push 3be3142d3aed981c2e1c35cd5861618b50d5089d.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.08%	installer size	windows2012-64		111,682,615.58 -> 111,595,139.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44173

For more information on performance sheriffing please see our FAQ.