Closed Bug 1949522 Opened 11 months ago Closed 5 months ago

Add linting rule to prevent using chrome://newtab or resource://newtab outside of browser/extensions/newtab and browser/components/newtab

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox144 fixed)

RESOLVED FIXED
144 Branch
Tracking Status
firefox144 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt-trainhop-project])

Attachments

(1 file)

We've worked hard to reduce the coupling here, and we should try to make it harder to accidentally couple in the future.

Component: New Tab Page → Lint and Formatting
Product: Firefox → Developer Infrastructure

Hey Mark,

I've never written a rule like the one described in this bug. Are you aware of any pre-existing examples I could work off of?

Flags: needinfo?(standard8)

I think the no-browser-refs-in-toolkit rule is probably closest to what you are looking for.

Flags: needinfo?(standard8)
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/557708a7745a https://hg.mozilla.org/integration/autoland/rev/532a71e761fd Add a linting rule to discourage external components from depending on newtab code. r=Standard8,frontend-codestyle-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch

Mass moving from [hnt-trainhop] to [hnt-trainhop-project] for better JIRA book-keeping.

Whiteboard: [hnt-trainhop] → [hnt-trainhop-project]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: