Closed
Bug 1949522
Opened 11 months ago
Closed 5 months ago
Add linting rule to prevent using chrome://newtab or resource://newtab outside of browser/extensions/newtab and browser/components/newtab
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox144 fixed)
RESOLVED
FIXED
144 Branch
| Tracking | Status | |
|---|---|---|
| firefox144 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt-trainhop-project])
Attachments
(1 file)
We've worked hard to reduce the coupling here, and we should try to make it harder to accidentally couple in the future.
Updated•11 months ago
|
| Assignee | ||
Updated•11 months ago
|
Component: New Tab Page → Lint and Formatting
Product: Firefox → Developer Infrastructure
| Assignee | ||
Comment 1•6 months ago
|
||
Hey Mark,
I've never written a rule like the one described in this bug. Are you aware of any pre-existing examples I could work off of?
Flags: needinfo?(standard8)
Comment 2•6 months ago
|
||
I think the no-browser-refs-in-toolkit rule is probably closest to what you are looking for.
Flags: needinfo?(standard8)
| Assignee | ||
Comment 3•5 months ago
|
||
Updated•5 months ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/557708a7745a
https://hg.mozilla.org/integration/autoland/rev/532a71e761fd
Add a linting rule to discourage external components from depending on newtab code. r=Standard8,frontend-codestyle-reviewers,Gijs
Comment 5•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox144:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
| Assignee | ||
Comment 6•6 days ago
|
||
Mass moving from [hnt-trainhop] to [hnt-trainhop-project] for better JIRA book-keeping.
Whiteboard: [hnt-trainhop] → [hnt-trainhop-project]
Updated•6 days ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•