1949683 - Network monitor doesn't handle NS_ERROR_NET_EMPTY_RESPONSE correctly

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Julian Descottes [:jdescottes]]

Will need to build a small test case, but it seems that DevTools network monitor doesn't handle the new NS_ERROR_NET_EMPTY_RESPONSE error correctly.

This status is used when browser.http.blank_page_with_error_response.enabled is set to false, when a 404/500 request has no content. Also leads to show a dedicated net error page instead of a blank page in case the request is a navigation request.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Julian, would you mind pointing to a page that does trigger this error?
We're not sure what the actual issue is here, are we missing a request in the netmonitor?

Thanks!

Comment 2

[Claas Augner [:claas]]

Nicolas, I can reproduce it with https://httpbin.org/status/404

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the link Claas.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: image.png

To clarify, the issue is that we show the request as failed, whereas it should be a valid "404".
You can toggle browser.http.blank_page_with_error_response.enabled to true to compare the behavior.

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1949683 - [devtools] Add NS_ERROR_NET_EMPTY_RESPONSE to the list of platform errors which are ignored r=#devtools

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf609adebfde
[devtools] Add NS_ERROR_NET_EMPTY_RESPONSE to the list of platform errors which are ignored r=devtools-reviewers,nchevobbe

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bf609adebfde