1949769 - Crash in [@ wl_proxy_marshal | wl_surface_attach]

Status: RESOLVED DUPLICATE of bug 1950610

(Core :: Graphics: WebRender, defect, P2)

Description

[GreyXor]

Crash report: https://crash-stats.mozilla.org/report/index/47c984a7-19eb-4a0e-99ca-a90fa0250221

Reason:

SIGSEGV / SI_KERNEL

Top 10 frames:

0  libwayland-client.so.0  wl_proxy_marshal  /usr/src/debug/wayland/wayland-1.23.1/src/wayland-client.c:973
1  libxul.so  wl_surface_attach(wl_surface*, wl_buffer*, int, int)  /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/wayland-client-protocol.h:1424
1  libxul.so  mozilla::widget::WaylandSurface::RemoveAttachedBufferLocked(mozilla::widget::...  widget/gtk/WaylandSurface.cpp:1253
2  libxul.so  mozilla::layers::NativeLayerRootWayland::Shutdown()  gfx/layers/NativeLayerWayland.cpp:184
3  libxul.so  mozilla::widget::GtkCompositorWidget::~GtkCompositorWidget()  widget/gtk/GtkCompositorWidget.cpp:60
4  libxul.so  mozilla::widget::InProcessGtkCompositorWidget::~InProcessGtkCompositorWidget()  widget/gtk/InProcessGtkCompositorWidget.h:16
5  libxul.so  mozilla::widget::CompositorWidget::Release()  widget/CompositorWidget.h:90
5  libxul.so  mozilla::RefPtrTraits<mozilla::widget::CompositorWidget>::Release(mozilla::wi...  mfbt/RefPtr.h:49
5  libxul.so  RefPtr<mozilla::widget::CompositorWidget>::ConstRemovingRefPtrTraits<mozilla:...  mfbt/RefPtr.h:409
5  libxul.so  RefPtr<mozilla::widget::CompositorWidget>::assign_assuming_AddRef(mozilla::wi...  mfbt/RefPtr.h:68

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1938033, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Do you have a reproduce for it? Can you run on terminal with MOZ_LOG="WidgetWayland:5" env variable and attach the log here?
Thanks.

Comment 3

[GreyXor]

I reproduce it empirically when I moved the tabs

Here the crash: https://crash-stats.mozilla.org/report/index/aac0e198-8068-4e63-b161-586f00250224
Here the logs :

[Parent 42297: Main Thread]: V/WidgetWayland [7f42f1271480]: WaylandSurface::FrameCallbackHandler() one-time 0 persistent 0 emulated 0 routed 1 force commit 0
[Parent 42297: Main Thread]: V/WidgetWayland [7f42e28c8c00]: WaylandSurface::RequestFrameCallbackLocked(), enabled 1 mapped 1 emulate 0 mFrameCallback 0
[Parent 42297: Main Thread]: V/WidgetWayland [7f42e28c8c00]: WaylandSurface::Commit() needs commit 1, force commit 0 flush 0
[Parent 42297: Renderer]: D/WidgetWayland [7f42e28c8c00]: WaylandSurface::UnmapLocked()
[Parent 42297: Renderer]: D/WidgetWayland [7f42e28c8c00]: WaylandSurface::ClearScaleLocked()
[Parent 42297: Renderer]: D/WidgetWayland [7f42e28c8c00]: WaylandSurface::ReleaseAllWaylandBuffersLocked(), buffers num 0
[Parent 42297: Main Thread]: D/WidgetWayland [7f42f1271480]: WaylandSurface::RemoveAttachedBufferLocked()
[Parent 42297: Main Thread]: V/WidgetWayland [7f42f1271480]: WaylandSurface::SetSizeLocked(): Size [0 x 0] unscaled size [0 x 0]
[Parent 42297: Main Thread]: D/WidgetWayland [7f42f1271480]: WaylandSurface::SetViewPortDestLocked(): Size [0 x 0]
ExceptionHandler::GenerateDump attempting to generate:/home/greyxor/.mozilla/firefox/9gu6g1ie.default-nightly/minidumps/272d67f6-9b73-2132-9708-9e31e215fe32.dmp

Comment 4

[GreyXor]

happens every time I move a tab in my tab bar, it crashes when I release my left click

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Please attach a full log, this one is too small.
Thanks.

Comment 6

[GreyXor]

Attachment: fail.txt

https://crash-stats.mozilla.org/report/index/e71eaa21-b617-4ab4-8daa-64d690250225
I moved tabs

Comment 7

[GreyXor]

seems resolved, I can now move tabs without crash with https://hg.mozilla.org/mozilla-central/rev/d0efb392c1783f46f27a946f48e3ef729ecd3675

Comment 8

[Martin Stránský [:stransky] (ni? me)]

I'd say it's rather dupe of Bug 1949726 or Bug 1950610.