1949964 - Incorrect language codes in Reader View reading time calculation

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Keita Minowa]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

When opening Reader View on any Japanese article, the displayed reading time does not appear to match the study referenced in the code comments (https://iovs.arvojournals.org/article.aspx?articleid=2166061).

The _getReadingSpeedForLanguage() function in toolkit/components/reader/ReaderMode.sys.mjs appears to use incorrect language codes for Japanese and Slovenian compared to the study referenced in the code comments. The correct language codes should be 'ja' for Japanese and 'sl' for Slovenian.

Actual results:

It seems that reading time is calculated using English data instead of Japanese data.

Expected results:

Japanese reading time should be calculated based on Japanese data.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Thanks!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1949964 - Use proper language codes for Japanese and Slovenian articles when calculating reading times in reader mode. r?nordzilla!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45d10dffbb3e
Use proper language codes for Japanese and Slovenian articles when calculating reading times in reader mode. r=nordzilla

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/45d10dffbb3e