1950058 - Clear-Site-Data: "cache": Use principal with correct originAttributes

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P2)

Description

[Manuel Bucher [:manuel]]

Currently we pass a principal that has unpartitioned originAttributes. This leads to clearing the wrong cache entries. Identify how to pass a principal with the correct originAttributes or modify the originAttributes in the clearOrigin cache function.

Comment 1

[Harshit Sohaney [:hsohaney]]

setting a severity since this is a defect

Comment 2

[Manuel Bucher [:manuel]]

• clear-site-cache.html wpts: https://pernos.co/debug/ypokdkBHKNZiArOxR2d0XA/index.html
• test_cache2_clear_with_principal.js: https://pernos.co/debug/jF5BhnwQN0X2k7lcRvMkkg/index.html

Comment 3

[Manuel Bucher [:manuel]]

Note from talking to Tim yesterday: The originAttributes seem correct. However, we also pass the origin to CacheStorageService::ClearOriginInternal and that is likely not honored correctly.

Comment 4

[Manuel Bucher [:manuel]]

• clear-site-cache.html with first oa fix and debug prints: https://pernos.co/debug/ctXxUO4DZbfrUa60HCjTXw/index.html

Comment 5

[Manuel Bucher [:manuel]]

Attachment: Bug 1950058 - Fix network cache cleaning from `Clear-Site-Data: "cache"` header r=#anti-tracking

This patch contains basically three fixes and could be split up into
three commits if preferred.

Fix 1: The originAttributes coming from predictor code didn't adjust
OriginAttributes for networking state. Therefore, both unpartitioned and
partitioned cache entries were written. This was fixed on the caller
side. It might make sense to do this on the callee side.

Fix 2: The originAttributes coming from Clear-Site-Data: "cache" code
didn't adjust the OriginAttributes for clearing for networking state.

Fix 3: The partitionKey PopulateTopLevelInfoFromURI didn't include the
port in some cases.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/988a49f32591
Fix network cache cleaning from `Clear-Site-Data: "cache"` header r=anti-tracking-reviewers,timhuang

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/988a49f32591