Closed Bug 195008 Opened 21 years ago Closed 21 years ago

Improve performance of nsICollation::CompareString

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 207634

People

(Reporter: nhottanscp, Assigned: nhottanscp)

Details

Attachments

(1 file)

Avoid creating sort keys, directly call WinAPI to compare strings.
2.76 KB, patch
Details | Diff | Splinter Review 
The current implementation of nsICollation::CompareString generates two
collation keys for a comparison. It can be inefficient because the comparison
may not require a whole string to be transformed to a collation key (e.g. may
unmatch at the first character).
As we use OS API to generate collation keys, we may also use OS API for
comparing string which might do that kind of optimization.
Attachment #117753 - Flags: review?(ftang)
I've implemented something fairly similar for bug 207634 because I needed to get
rid of nsCollation::CompareString

*** This bug has been marked as a duplicate of 207634 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Attachment #117753 - Flags: review?(ftang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: